From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
"Aaron Lu" <aaron.lu@intel.com>,
"Matthew Garrett" <mjg59@srcf.ucam.org>,
"* SAMÍ *" <miaousami@hotmail.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
"ACPI Devel Maling List" <linux-acpi@vger.kernel.org>,
"Igor Gnatenko" <i.gnatenko.brain@gmail.com>
Subject: Re: [Intel-gfx] Linux 3.11-rc2 [backlight] [ASUS N56VZ]
Date: Wed, 24 Jul 2013 23:02:00 +0200 [thread overview]
Message-ID: <20130724210200.GY5939@phenom.ffwll.local> (raw)
In-Reply-To: <CA+55aFzDgAcrzkkq06Qe9CBbBv6xKMYwPqtwv+ACryRSTRDOSQ@mail.gmail.com>
On Wed, Jul 24, 2013 at 10:39 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Wed, Jul 24, 2013 at 12:39 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>>
>> Well, there seems to be a number of people who'll be equally unhappy if I don't
>> do that. Unfortunately for you, things work for them without that patch.
>
> So I think we have to revert the behavior back, but I wonder if we
> could keep the logic and have a i915 kernel command line option to
> enable it.
>
> We did that for a long time with "drm.modeset" and the
> "i915.enable_rc6" mess. We still have the "i915.invert_brightness"
> thing, although I don't know who actually uses it. But that option is
> itself an indication that the i915 driver still has some backlight
> issues.
invert_brighntess seems to be real, at least we have a pile of quirk
entries for Acer and Packard Bell machines. Generally I'm not too happy
with module options since they tend to get stuck eternally in a limbo
state where everyone in the know sets them to their liking and no one
bothers to fix the underlying.
Otoh this is the backlight and I've essentially given up and opted for
quirk entries :(
> But if that kind of "revert behavior" isn't easy, we need to just
> revert the patches entirely.
I think a i915 module option should be doable, otoh people seem to have a
viable workaround by setting a different acpi os version already.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-07-24 21:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 18:43 Linux 3.11-rc2 [backlight] [ASUS N56VZ] * SAMÍ *
[not found] ` <CAFMg4WB21dWV6c+hxzrXR_0pSfnayFPZGx0byX6pKjMS5SDoqQ@mail.gmail.com>
2013-07-24 19:29 ` Rafael J. Wysocki
2013-07-24 19:39 ` Rafael J. Wysocki
2013-07-24 20:39 ` Linus Torvalds
2013-07-24 21:02 ` Daniel Vetter [this message]
2013-07-24 21:05 ` [Intel-gfx] " Linus Torvalds
2013-07-24 21:23 ` Rafael J. Wysocki
2013-07-25 8:09 ` Jani Nikula
2013-07-25 11:58 ` Rafael J. Wysocki
2013-07-25 12:34 ` Jani Nikula
2013-07-25 12:57 ` Rafael J. Wysocki
2013-07-29 19:36 ` * SAMÍ *
2013-07-29 20:03 ` Rafael J. Wysocki
2013-07-29 21:53 ` * SAMÍ *
2013-07-29 22:11 ` Rafael J. Wysocki
2013-07-29 23:38 ` Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130724210200.GY5939@phenom.ffwll.local \
--to=daniel.vetter@ffwll.ch \
--cc=aaron.lu@intel.com \
--cc=i.gnatenko.brain@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaousami@hotmail.com \
--cc=mjg59@srcf.ucam.org \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox