From: Greg KH <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Won Kang <wkang77@gmail.com>,
devel@driverdev.osuosl.org, wonkang@gctsemi.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver
Date: Wed, 24 Jul 2013 15:06:31 -0700 [thread overview]
Message-ID: <20130724220631.GA10541@kroah.com> (raw)
In-Reply-To: <20130724215340.GY5585@mwanda>
On Thu, Jul 25, 2013 at 12:53:40AM +0300, Dan Carpenter wrote:
> > +static int gdm_lte_ioctl_get_data(struct wm_req_t *req, struct net_device *dev)
> > +{
> > + u16 id = req->data_id;
> > +
> > + switch (id) {
> > + case GET_ENDIAN_INFO:
> > + /* required for the user space application to find out device endian */
> > + get_dev_endian(&req->data, dev);
> > + break;
> > + default:
> > + printk(KERN_ERR "glte: ioctl - unknown type %d\n", id);
> > + break;
> > + }
> > + return 0;
> > +}
>
> This should be a sysfs file not an ioctl. What would break if we
> fixed this right now (as opposed to waiting until we can't change
> the API?).
>
> Otherwise if we can't change this, then it should return an error
> code instead of printing a message.
It should just be removed, why would you care about the endian-ness of
the device at all?
thanks,
greg k-h
next prev parent reply other threads:[~2013-07-24 22:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 6:56 [PATCH 1/2] staging: gdm7240: adding LTE USB driver Won Kang
2013-07-22 6:56 ` [PATCH 2/2] staging: gdm7240: added contacts for code maintanance Won Kang
2013-07-22 7:29 ` Joe Perches
2013-07-22 15:13 ` Greg KH
2013-07-22 18:27 ` [PATCH 1/2] staging: gdm7240: adding LTE USB driver Dan Carpenter
2013-07-24 18:36 ` [PATCH v2 " Won Kang
2013-07-24 18:41 ` Joe Perches
2013-07-24 18:50 ` 회신: " Won Kang
2013-07-24 20:34 ` Greg KH
2013-07-24 21:08 ` Dan Carpenter
2013-07-24 21:53 ` Dan Carpenter
2013-07-24 22:06 ` Greg KH [this message]
2013-07-25 4:15 ` Won Kang
2013-07-25 4:37 ` Greg KH
2013-07-25 5:56 ` Won Kang
2013-07-25 17:01 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130724220631.GA10541@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wkang77@gmail.com \
--cc=wonkang@gctsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox