From: Felipe Balbi <balbi@ti.com>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Cc: <balbi@ti.com>, <linux-arm-msm@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 7/7] usb: phy: msm: Lindent the code
Date: Thu, 25 Jul 2013 17:22:08 +0300 [thread overview]
Message-ID: <20130725142208.GC16106@radagast> (raw)
In-Reply-To: <1374759651.1956.29.camel@iivanov-dev.int.mm-sol.com>
[-- Attachment #1: Type: text/plain, Size: 930 bytes --]
Hi,
On Thu, Jul 25, 2013 at 04:40:51PM +0300, Ivan T. Ivanov wrote:
> > > diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
> > > index 6d05085..111f454 100644
> > > --- a/drivers/usb/phy/phy-msm-usb.c
> > > +++ b/drivers/usb/phy/phy-msm-usb.c
> > > @@ -64,8 +64,8 @@ static int msm_hsusb_init_vddcx(struct msm_otg *motg, int init)
> > >
> > > if (init) {
> > > ret = regulator_set_voltage(motg->vddcx,
> > > - USB_PHY_VDD_DIG_VOL_MIN,
> > > - USB_PHY_VDD_DIG_VOL_MAX);
> > > + USB_PHY_VDD_DIG_VOL_MIN,
> > > + USB_PHY_VDD_DIG_VOL_MAX);
> >
> > like here, what's the point ?
>
> It makes indentation the same like the majority of the code.
> I could drop this patch if you like.
yeah, I don't think it's worth to have this patch. Just looked at the
driver and, at least to my eyes, it didn't look all that bad. Matter of
taste though
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-07-25 14:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1372087664-26396-1-git-send-email-iivanov@mm-sol.com>
2013-06-24 15:27 ` [PATCH 1/7] usb: phy: msm: Move mach dependent code to platform data Ivan T. Ivanov
2013-07-24 12:23 ` Felipe Balbi
2013-07-24 15:55 ` David Brown
2013-07-26 9:11 ` Ivan T. Ivanov
2013-06-24 15:27 ` [PATCH 2/7] usb: phy: msm: Migrate to Managed Device Resource allocation Ivan T. Ivanov
2013-06-24 15:27 ` [PATCH 3/7] usb: phy: msm: Move regulator usage to managed resource allocation Ivan T. Ivanov
2013-06-24 15:27 ` [PATCH 4/7] usb: phy: msm: Remove unnecessarily check for valid regulators Ivan T. Ivanov
2013-06-24 15:27 ` [PATCH 5/7] usb: phy: msm: Fix WARNING: quoted string split across lines Ivan T. Ivanov
2013-06-24 15:27 ` [PATCH 6/7] usb: phy: msm: Fix WARNING: Prefer seq_puts to seq_printf Ivan T. Ivanov
2013-06-24 15:27 ` [PATCH 7/7] usb: phy: msm: Lindent the code Ivan T. Ivanov
2013-07-24 12:22 ` Felipe Balbi
2013-07-25 13:40 ` Ivan T. Ivanov
2013-07-25 14:22 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130725142208.GC16106@radagast \
--to=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=iivanov@mm-sol.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox