Re: [PATCH] usb: gadget: at91_udc: Check gpio lookup results

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1564 bytes --]

Hi,

On Tue, Jul 23, 2013 at 11:55:50AM -0700, Olof Johansson wrote:
> This resolves the following valid build warning:
> 
> drivers/usb/gadget/at91_udc.c:1685:34: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 
> I switched from ? : to !! mostly to save from wrapping the lines while
> I was at it.
> 
> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
> 
> Felipe, this would be nice to see fixed for 3.11 but I'd argue that it's
> been here long enough to not really be needed for -stable.
> 
>  drivers/usb/gadget/at91_udc.c |   12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
> index 073b938..f3dbcd0 100644
> --- a/drivers/usb/gadget/at91_udc.c
> +++ b/drivers/usb/gadget/at91_udc.c
> @@ -1682,12 +1682,20 @@ static void at91udc_of_init(struct at91_udc *udc,
>  
>  	board->vbus_pin = of_get_named_gpio_flags(np, "atmel,vbus-gpio", 0,
>  						  &flags);
> -	board->vbus_active_low = (flags & OF_GPIO_ACTIVE_LOW) ? 1 : 0;
> +	if (board->vbus_pin < 0)
> +		pr_err("%s: Failed to get atmel,vbus-gpio property\n",
> +		       np->full_name);
> +	else
> +		board->vbus_active_low = !!(flags & OF_GPIO_ACTIVE_LOW);

should you even continue if you can't get the gpio ? If this gpio is
optional, then it's not really and error, rather a debugging or
informational message.

BTW, this vbus-gpio looks, to me at least, like a fixed regulator
controlled by a GPIO, no ?

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]