From: Mark Brown <broonie@kernel.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
Krystian Garbaciak <krystian.garbaciak@diasemi.com>
Subject: Re: [PATCH 2/2] regulator: Add Dialog DA9063 voltage regulators support.
Date: Thu, 25 Jul 2013 19:01:45 +0100 [thread overview]
Message-ID: <20130725180145.GL9858@sirena.org.uk> (raw)
In-Reply-To: <1374773739.4382.18.camel@pizza.hi.pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 745 bytes --]
On Thu, Jul 25, 2013 at 07:35:39PM +0200, Philipp Zabel wrote:
> Am Mittwoch, den 24.07.2013, 18:29 +0100 schrieb Mark Brown:
> > This looks like it should be generic (and there is actually a
> > regmap_field API for bitfields...).
> Indeed. I'm a bit unhappy about having to split all the masks into lsb and msb
> only to have regmap_field_init combine them back into a mask, though.
> Could we perhaps change struct reg_field to contain reg and mask, and then also use
> this for the regulator_desc vsel/apply/enable/bypass_reg/mask fields?
Well, the other option is to define regmap regulator helpers for
everything where there's overlap and just do that. The helpers cover a
bunch of common things but there's going to be room for more.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-07-25 18:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 16:34 [PATCH 0/2] Add Dialog DA9063 core and regulator drivers Philipp Zabel
2013-07-24 16:34 ` [PATCH 1/2] mfd: Add Dialog DA9063 core driver Philipp Zabel
2013-07-24 17:07 ` Mark Brown
2013-07-25 11:00 ` Philipp Zabel
2013-07-25 8:04 ` Lee Jones
2013-07-25 8:08 ` Lee Jones
2013-07-25 17:34 ` Philipp Zabel
2013-07-25 18:00 ` Mark Brown
2013-07-29 15:46 ` Lee Jones
2013-07-29 15:57 ` Samuel Ortiz
2013-07-29 15:57 ` Philipp Zabel
2013-07-24 16:34 ` [PATCH 2/2] regulator: Add Dialog DA9063 voltage regulators support Philipp Zabel
2013-07-24 17:29 ` Mark Brown
2013-07-25 17:35 ` Philipp Zabel
2013-07-25 18:01 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130725180145.GL9858@sirena.org.uk \
--to=broonie@kernel.org \
--cc=krystian.garbaciak@diasemi.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox