From: Dan Carpenter <dan.carpenter@oracle.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: gregkh@linuxfoundation.org, wonkang@gctsemi.com, joe@perches.com,
devel@driverdev.osuosl.org, yongjun_wei@trendmicro.com.cn,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] staging: gdm724x: use GFP_ATOMIC under spin lock
Date: Fri, 26 Jul 2013 10:32:33 +0300 [thread overview]
Message-ID: <20130726073233.GD5585@mwanda> (raw)
In-Reply-To: <CAPgLHd-WN2VF7vEjUn0uLd_RQYYF1qvUy1TUz4EmyPbi=8JQ4g@mail.gmail.com>
On Fri, Jul 26, 2013 at 10:15:55AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> A spin lock is taken here so we should use GFP_ATOMIC.
>
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
But the locking here is really odd and pointless. usb_submit_urb()
returns asynchronously before the data has been sent, so there is
almost no point in locking around it.
regards,
dan carpenter
next prev parent reply other threads:[~2013-07-26 7:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 2:15 [PATCH -next] staging: gdm724x: use GFP_ATOMIC under spin lock Wei Yongjun
2013-07-26 7:32 ` Dan Carpenter [this message]
2013-07-26 22:04 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130726073233.GD5585@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
--cc=wonkang@gctsemi.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox