public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] workqueue: clear workers of a pool after the CPU is offline
Date: Fri, 26 Jul 2013 06:22:40 -0400	[thread overview]
Message-ID: <20130726102240.GA30786@mtj.dyndns.org> (raw)
In-Reply-To: <51F1F138.2060902@cn.fujitsu.com>

On Fri, Jul 26, 2013 at 11:47:04AM +0800, Lai Jiangshan wrote:
> any worker can't kill itself.
> managers always tries to leave 2 workers.
> 
> so the workers of the offline cpu pool can't be totally destroyed.

But we *do* want to keep them around as CPUs taken offline are likely
to come online at some point and destroying all of them saves only
~16k of memory while adding more work while CPUs are on/offlined which
can be very frequent on mobile devices.  The change was *intentional*.

Thanks.

-- 
tejun

  reply	other threads:[~2013-07-26 10:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25 10:52 [PATCH] workqueue: clear workers of a pool after the CPU is offline Lai Jiangshan
2013-07-25 15:31 ` Tejun Heo
2013-07-26  2:13   ` Lai Jiangshan
2013-07-26  3:07     ` Tejun Heo
2013-07-26  3:47       ` Lai Jiangshan
2013-07-26 10:22         ` Tejun Heo [this message]
2013-07-26 16:55           ` Lai Jiangshan
2013-07-26 17:03             ` Tejun Heo
  -- strict thread matches above, loose matches on Subject: below --
2013-02-20 17:04 Lai Jiangshan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130726102240.GA30786@mtj.dyndns.org \
    --to=tj@kernel.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox