Re: [PATCH 2/4] ASoc: kirkwood: simplify probe error

Mark Brown
2013-07-25T19:11:09Z

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

On Thu, Jul 25, 2013 at 11:13:57AM +0200, Jean-Francois Moine wrote:
> The function kirkwood_i2s_dev_remove() may be used when probe fails.

This seems fine but doesn't apply against current code but otherwise
seems fine.

> + if (!IS_ERR(priv->extclk)) {
> + clk_disable_unprepare(priv->extclk);
> + clk_put(priv->extclk);
> + }

Could use devm_clk_get() for extclk.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]