linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: grant.likely@linaro.org, linus.walleij@linaro.org,
	rob.herring@calxeda.com, rob@landley.net, sameo@linux.intel.com,
	lee.jones@linaro.org, devicetree-discuss@lists.ozlabs.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	gg@slimlogic.co.uk, kishon@ti.com, swarren@nvidia.com,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: palmas: add pincontrol driver
Date: Fri, 26 Jul 2013 17:41:22 +0100	[thread overview]
Message-ID: <20130726164122.GT9858@sirena.org.uk> (raw)
In-Reply-To: <1374833754-19659-3-git-send-email-ldewangan@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

On Fri, Jul 26, 2013 at 03:45:54PM +0530, Laxman Dewangan wrote:

> +pins: gpio0_id, gpio1_vbus_det_led1_pwm1, gpio2_regen_led2_pwm2, gpio3_chrg_det,
> +	gpio4_sysen1, gpio5_clk32kgaudio_usb_psel, gpio6_sysen2,
> +	gpio7_msecure_pwrhold, gpio8_sim1rsti, gpio9_low_vbat,
> +	gpio10_wireless_chrg1, gpio11_rcm, gpio12_sim2rsto, gpio13, gpio14,
> +	gpio15_sim2rsti, vac, powergood_usb_psel, nreswarm, pwrdown,
> +	gpadc_start, reset_in, nsleep, enable1, enable2, int.

Would it not be easier to just name the GPIOs gpioN rather than using
the full names with the possible functions?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2013-07-26 16:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-26 10:15 [PATCH 0/2] pinctrl: palmas: add pincontrol driver Laxman Dewangan
2013-07-26 10:15 ` [PATCH 1/2] pinctrl: pinconf_generic: add utility functions for add map/configs Laxman Dewangan
2013-07-26 17:36   ` Stephen Warren
2013-07-27 10:14     ` Laxman Dewangan
2013-07-29 16:38       ` Stephen Warren
2013-08-07 18:27     ` Linus Walleij
2013-08-08  7:23       ` Laxman Dewangan
2013-07-26 10:15 ` [PATCH 2/2] pinctrl: palmas: add pincontrol driver Laxman Dewangan
2013-07-26 16:41   ` Mark Brown [this message]
2013-07-27 10:23     ` Laxman Dewangan
2013-07-28 12:20       ` Mark Brown
2013-07-26 19:09   ` Stephen Warren
2013-07-27 12:11     ` Laxman Dewangan
2013-07-29 16:45       ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130726164122.GT9858@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gg@slimlogic.co.uk \
    --cc=grant.likely@linaro.org \
    --cc=kishon@ti.com \
    --cc=ldewangan@nvidia.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=sameo@linux.intel.com \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).