From: Borislav Petkov <bp@alien8.de>
To: "zhangwei(Jovi)" <jovi.zhangwei@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Steven Rostedt <rostedt@goodmis.org>,
Jens Axboe <axboe@kernel.dk>, Al Viro <viro@zeniv.linux.org.uk>,
Eric Dumazet <edumazet@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] relay: fix timer madness v3
Date: Sat, 27 Jul 2013 12:26:27 +0200 [thread overview]
Message-ID: <20130727102627.GB6923@pd.tnic> (raw)
In-Reply-To: <51F3710B.3040304@huawei.com>
On Sat, Jul 27, 2013 at 03:04:43PM +0800, zhangwei(Jovi) wrote:
> Changed from v2:
> mod timer interval changed from HZ/10 to jiffies + HZ/10,
> as Dan Carpenter suggested.
>
> This patch is based on -mm tree.
This is one of those guess-what-I'm-thinking commit messages. Can you
please write it this way:
The situation currently is A, the bug is B, I'm fixing it by doing C.
Don't be afraid to be more verbose.
An innocent bystander can only guess why the change was done and I'm
willing to bet good money that a couple of years from now, not even you
will know why you did it.
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
prev parent reply other threads:[~2013-07-27 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-27 7:04 [PATCH] relay: fix timer madness v3 zhangwei(Jovi)
2013-07-27 10:26 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130727102627.GB6923@pd.tnic \
--to=bp@alien8.de \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dan.carpenter@oracle.com \
--cc=edumazet@google.com \
--cc=jovi.zhangwei@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox