From: Greg KH <gregkh@linuxfoundation.org>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: "arnd@arndb.de" <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Ovsyanikov, Natalia" <natalia.ovsyanikov@intel.com>
Subject: Re: [char-misc-next 2/3] mei: adding sysfs fw_status attribute
Date: Sun, 28 Jul 2013 08:31:55 -0700 [thread overview]
Message-ID: <20130728153155.GA6781@kroah.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B1AE76B1B@HASMSX106.ger.corp.intel.com>
On Sun, Jul 28, 2013 at 08:48:24AM +0000, Winkler, Tomas wrote:
> > On Wed, Jul 24, 2013 at 06:04:33PM +0000, Winkler, Tomas wrote:
> > >
> > >
> > > > >
> > > > > Just to make sure, is this what you're suggesting ?
> > > > >
> > > > > device->groups = mei_attr_groups
> > > > > mei_misc_device.parent = device;
> > > > > ret = misc_register(&mei_misc_device);
> > > >
> > > > Yes, that should work. If not, please let me know, the code
> > > > underwent some changes in 3.11-rc2.
> > >
> > > I don' t see the file being created.
> > > Not sure if the misc_register setup the parent sysfs as well.
> >
> > Oops, wait, the parent is already registered, that's not going to work, you
> > want to create the files for the device itself that you are creating, so set the -
> > >groups field for that device.
> >
> > sorry about that.
>
> So is this okay to go as is?
What is "this"?
next prev parent reply other threads:[~2013-07-28 15:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 15:41 [char-misc-next 0/3] mei: export fw status register through sysfs Tomas Winkler
2013-07-24 15:41 ` [char-misc-next 1/3] mei me: add handler for me_hw_ops fw_status Tomas Winkler
2013-07-24 15:41 ` [char-misc-next 2/3] mei: adding sysfs fw_status attribute Tomas Winkler
2013-07-24 16:00 ` Greg KH
2013-07-24 16:20 ` Winkler, Tomas
2013-07-24 16:26 ` Greg KH
2013-07-24 18:04 ` Winkler, Tomas
2013-07-24 20:29 ` Greg KH
2013-07-28 8:48 ` Winkler, Tomas
2013-07-28 15:31 ` Greg KH [this message]
2013-07-29 22:27 ` Winkler, Tomas
2013-07-29 22:38 ` Greg KH
2013-07-29 23:08 ` Winkler, Tomas
2013-07-29 23:17 ` Greg KH
2013-08-01 7:21 ` Winkler, Tomas
2013-08-01 7:32 ` Greg KH
2013-07-24 15:41 ` [char-misc-next 3/3] mei: update ABI for fw_status register exported through sysfs Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130728153155.GA6781@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=natalia.ovsyanikov@intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox