From: Tejun Heo <tj@kernel.org>
To: Shaohua Li <shli@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch]workqueue: copy attr with all fields.
Date: Mon, 29 Jul 2013 07:14:01 -0400 [thread overview]
Message-ID: <20130729111401.GA20951@mtj.dyndns.org> (raw)
In-Reply-To: <20130729062412.GA6448@kernel.org>
Hello, Shaohua.
On Mon, Jul 29, 2013 at 02:24:12PM +0800, Shaohua Li wrote:
> copy_workqueue_attrs() forgets to copy no_numa field.
Explaining how that affects things and how the behavior changes
afterwards would be nice. As it currently stands, I don't know why
you're submitting this patch. Is this a bug fix? Just a consistency
update? Should it be marked with -stable?
Please put more effort into patch descriptions and also note that
->no_numa isn't a pool attribute as noted in the comment above struct
workqueue_attrs definition.
Thanks.
--
tejun
next prev parent reply other threads:[~2013-07-29 11:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 6:24 [patch]workqueue: copy attr with all fields Shaohua Li
2013-07-29 11:14 ` Tejun Heo [this message]
2013-07-29 12:52 ` Shaohua Li
2013-07-29 15:35 ` Tejun Heo
2013-07-30 5:49 ` Shaohua Li
2013-07-30 14:14 ` Tejun Heo
2013-07-31 1:39 ` Shaohua Li
2013-07-31 10:27 ` Tejun Heo
2013-08-01 1:56 ` Shaohua Li
2013-08-01 12:35 ` [PATCH] workqueue: copy workqueue_attrs " Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130729111401.GA20951@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).