Re: [PATCH v2 1/6] usb: phy: msm: Move mach depndend code to platform data

Ivan T. Ivanov
2013-07-29T19:03:03Z

Hi,

> > Cc: Bryan Huntsman <bryanh@codeaurora.org>
> > Cc: Felipe Balbi <balbi@ti.com>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: linux-arm-kernel@lists.infradead.org
> > Cc: linux-kernel@vger.kernel.org
> > Cc: linux-usb@vger.kernel.org
> >
> > Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
> > ---
> > arch/arm/mach-msm/board-msm7x30.c | 35 +++++++++++++++++++++++
> > arch/arm/mach-msm/board-qsd8x50.c | 35 +++++++++++++++++++++++
>
> I need acks for these.
>
> > drivers/usb/phy/phy-msm-usb.c | 55 ++++++++++---------------------------
> > include/linux/usb/msm_hsusb.h | 3 ++
> > 4 files changed, 87 insertions(+), 41 deletions(-)
> >
> > diff --git a/arch/arm/mach-msm/board-msm7x30.c b/arch/arm/mach-msm/board-msm7x30.c
> > index db3d8c0..6b35953 100644
> > --- a/arch/arm/mach-msm/board-msm7x30.c
> > +++ b/arch/arm/mach-msm/board-msm7x30.c
> > @@ -31,6 +31,7 @@
> > #include <asm/setup.h>
> >
> > #include <mach/board.h>
> > +#include <mach/clk.h>
> > #include <mach/msm_iomap.h>
> > #include <mach/dma.h>
> >
> > @@ -61,10 +62,44 @@ static int hsusb_phy_init_seq[] = {
> > -1
> > };
> >
> > +static int hsusb_link_clk_reset(struct clk *link_clk, bool assert)
>
> looks like you should be using the reset controller framework ?
> (drivers/reset)

Probably, but there still nothing in place in the msm,
which provide this functionality. I am looking it to
right now.

Regards,
Ivan