From: Samuel Ortiz <sameo@linux.intel.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Krystian Garbaciak <krystian.garbaciak@diasemi.com>
Subject: Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver.
Date: Mon, 29 Jul 2013 17:57:27 +0200 [thread overview]
Message-ID: <20130729155727.GA11830@zurbaran> (raw)
In-Reply-To: <20130729154614.GA7704@gmail.com>
Hi Lee,
On Mon, Jul 29, 2013 at 04:46:14PM +0100, Lee Jones wrote:
> > > > > Signed-off-by: Krystian Garbaciak <krystian.garbaciak@diasemi.com>
> > > > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > > > > ---
> > > > > drivers/mfd/Kconfig | 12 +
> > > > > drivers/mfd/Makefile | 3 +
> > > > > drivers/mfd/da9063-core.c | 177 ++++++
> > > > > drivers/mfd/da9063-i2c.c | 197 ++++++
> > > > > drivers/mfd/da9063-irq.c | 193 ++++++
> > > > > include/linux/mfd/da9063/core.h | 110 ++++
> > > > > include/linux/mfd/da9063/pdata.h | 114 ++++
> > > > > include/linux/mfd/da9063/registers.h | 1090 ++++++++++++++++++++++++++++++++++
> > > > > 8 files changed, 1896 insertions(+)
> > > >
> > > > Whoah!! Who's going to want to review a 2k line patch?
> >
> > Well, most of those lines consist of the register and bit(field)
> > definitions and the assignment of those to regmap and regmap-irq.
> >
> > I could split this into (core+i2c) and (irq) parts if you insist.
>
> I won't insist on it,
I would. Smaller patches are easier to review, track and bisect.
So if you can logically split this patch into smaller pieces,, then
please do so.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2013-07-29 15:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 16:34 [PATCH 0/2] Add Dialog DA9063 core and regulator drivers Philipp Zabel
2013-07-24 16:34 ` [PATCH 1/2] mfd: Add Dialog DA9063 core driver Philipp Zabel
2013-07-24 17:07 ` Mark Brown
2013-07-25 11:00 ` Philipp Zabel
2013-07-25 8:04 ` Lee Jones
2013-07-25 8:08 ` Lee Jones
2013-07-25 17:34 ` Philipp Zabel
2013-07-25 18:00 ` Mark Brown
2013-07-29 15:46 ` Lee Jones
2013-07-29 15:57 ` Samuel Ortiz [this message]
2013-07-29 15:57 ` Philipp Zabel
2013-07-24 16:34 ` [PATCH 2/2] regulator: Add Dialog DA9063 voltage regulators support Philipp Zabel
2013-07-24 17:29 ` Mark Brown
2013-07-25 17:35 ` Philipp Zabel
2013-07-25 18:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130729155727.GA11830@zurbaran \
--to=sameo@linux.intel.com \
--cc=broonie@kernel.org \
--cc=krystian.garbaciak@diasemi.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox