From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Felipe Balbi <balbi@ti.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
george.cherian@ti.com
Subject: Re: [PATCH 2/4] usb: phy: add am335x pieces to generic phy
Date: Mon, 29 Jul 2013 17:58:43 +0200 [thread overview]
Message-ID: <20130729155843.GC827@linutronix.de> (raw)
In-Reply-To: <20130729122218.GG24801@radagast>
* Felipe Balbi | 2013-07-29 15:22:18 [+0300]:
>On Fri, Jul 26, 2013 at 10:15:55PM +0200, Sebastian Andrzej Siewior wrote:
>> This patch copies the phy support bits from dsps into the generic phy
>> driver. Most code can be re-used except for the on/off.
>> The additional am335x can be removed once we have a phy driver that does
>> more than this.
>>
>> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
>this is good too, but looking at the amount of am335x-specific code in
>the driver now it makes me wonder if we want to convert phy-generic.c
>into a library...
So I just looked over George Cherian phy driver. I think the simplest
thing would be to add the usb wakeup path to the driver here. Earlier I
hoped that we could just remove the am335x bits and avoid the library
thingy :)
Since the library probably makes sense:
- before or after this patch
- where do I get the memory for this wakeup register? It is somewhere in
the "reset module" of the am335x
Sebastian
next prev parent reply other threads:[~2013-07-29 15:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 20:15 am335x: support for multiple USB instances Sebastian Andrzej Siewior
2013-07-26 20:15 ` [PATCH 1/4] usb: phy: rename nop_usb_xceiv => usb_phy_gen_xceiv Sebastian Andrzej Siewior
2013-07-29 12:20 ` Felipe Balbi
2013-07-30 7:08 ` Tony Lindgren
2013-07-30 7:34 ` Sebastian Andrzej Siewior
2013-07-30 7:56 ` Tony Lindgren
2013-07-30 9:57 ` Sebastian Andrzej Siewior
2013-07-26 20:15 ` [PATCH 2/4] usb: phy: add am335x pieces to generic phy Sebastian Andrzej Siewior
2013-07-29 12:22 ` Felipe Balbi
2013-07-29 15:58 ` Sebastian Andrzej Siewior [this message]
2013-07-26 20:15 ` [PATCH 3/4] usb: musb: dsps: remove the hardcoded phy pieces Sebastian Andrzej Siewior
2013-07-26 20:15 ` [PATCH 4/4] usb: musb: dsps: use proper child nodes Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130729155843.GC827@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=balbi@ti.com \
--cc=george.cherian@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox