linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	cgroups@vger.kernel.org, containers@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, kent.overstreet@gmail.com,
	Li Zefan <lizefan@huawei.com>, Glauber Costa <glommer@gmail.com>,
	Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: memcg creates an unkillable task in 3.2-rc2
Date: Mon, 29 Jul 2013 12:10:26 -0400	[thread overview]
Message-ID: <20130729161026.GD22605@mtj.dyndns.org> (raw)
In-Reply-To: <20130729095109.GB4678@dhcp22.suse.cz>

Hello,

On Mon, Jul 29, 2013 at 11:51:09AM +0200, Michal Hocko wrote:
> Isn't this a bug in freezer then? I am not familiar with the freezer
> much but memcg oom handling seems correct to me. The task is sleeping
> KILLABLE and fatal_signal_pending in mem_cgroup_handle_oom will tell us
> to bypass the charge and let the taks go away.

Is the problem a frozen task not being killed even when SIGKILL is
received?  If so, it is a known problem and a side-effect of
cgroup_freezer (ab)using and making the existing power management
freezer visible to userland without really thinking about the
implications.  :(

So, yeah, if you use cgroup_freezer now, the tasks will get stuck in
states which aren't well defined when visible from userland and will
just stay there until unfrozen no matter what.  Yet another reason
I'll be screaming like a banshee at anyone who says that cgroup is
built to delegate subtree access rights to !root users.

It's on the to-do list but a very long term one.  Right now, if you
combine userland OOM handling with freezer and whatnot, it'd be pretty
easy to get into trouble.

Thanks.

-- 
tejun

  parent reply	other threads:[~2013-07-29 16:10 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23 17:47 [GIT PULL] cgroup changes for 3.11-rc2 Tejun Heo
2013-07-29  0:42 ` memcg creates an unkillable task in 3.2-rc2 Eric W. Biederman
2013-07-29  7:59   ` Michal Hocko
2013-07-29  8:54     ` Eric W. Biederman
2013-07-29  9:51       ` Michal Hocko
2013-07-29 10:21         ` Eric W. Biederman
2013-07-29 16:10         ` Tejun Heo [this message]
2013-07-29 17:03           ` Eric W. Biederman
2013-07-29 17:20             ` Tejun Heo
2013-07-29 18:06               ` Eric W. Biederman
2013-07-29 18:17               ` Michal Hocko
2013-07-29 18:13             ` Johannes Weiner
2013-07-29 18:52               ` Eric W. Biederman
2013-07-30  1:58             ` Li Zefan
2013-07-30  8:19               ` memcg creates an unkillable task in 3.11-rc2 Eric W. Biederman
2013-07-30 12:31                 ` Michal Hocko
2013-07-30 16:37                   ` Eric W. Biederman
2013-07-31  7:37                     ` Michal Hocko
2013-07-31 12:10                       ` Johannes Weiner
2013-07-31 22:09                       ` Eric W. Biederman
2013-08-01  9:06                         ` Michal Hocko
2013-09-05  9:56                           ` Michal Hocko
2013-09-06 18:09                             ` Eric W. Biederman
2013-09-09  8:31                               ` Michal Hocko
2013-07-30 16:28                 ` Eric W. Biederman
2013-09-26 23:41                   ` Fabio Kung
2013-09-27  0:35                     ` Eric W. Biederman
2013-11-12 16:00                     ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130729161026.GD22605@mtj.dyndns.org \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=glommer@gmail.com \
    --cc=hannes@cmpxchg.org \
    --cc=kent.overstreet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=mhocko@suse.cz \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).