From: Oleg Nesterov <oleg@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Alexander Z Lam <azl@google.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
David Sharp <dhsharp@google.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Vaibhav Nagarnaik <vnagarnaik@google.com>,
"zhangwei(Jovi)" <jovi.zhangwei@huawei.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/1] tracing: trace_remove_event_call() should fail if call/file is in use
Date: Mon, 29 Jul 2013 19:50:08 +0200 [thread overview]
Message-ID: <20130729175008.GA26284@redhat.com> (raw)
Hello.
On top of "[PATCH v2 0/6] tracing: open/delete fixes" series.
Perhaps this series should be updated, Masami has some concerns.
But it seems that you both mostly agree with these changes, so
let me send the "last" patch for review.
The last change in kernel/trace/trace_events.c we need to close the
problems with create/use/delete (at least those which I know ;).
Now we are ready to change trace_kprobe.c and trace_uprobe.c, Steven
already has the patches.
Changes:
- remove the TRACE_EVENT_FL_REF_MASK (which we do not have)
check.
We rely on the previous changes, we do not care if someone
have an opened file, event_enable_write/etc can do nothing
but fail after we do remove_event_file_dir().
- Add the comment and a note into the changelog to explain
why we still need to check FTRACE_EVENT_FL_ENABLED.
Oleg.
include/linux/ftrace_event.h | 2 +-
kernel/trace/trace_events.c | 35 +++++++++++++++++++++++++++++++++--
2 files changed, 34 insertions(+), 3 deletions(-)
next reply other threads:[~2013-07-29 17:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 17:50 Oleg Nesterov [this message]
2013-07-29 17:50 ` [PATCH v2 1/1] tracing: trace_remove_event_call() should fail if call/file is in use Oleg Nesterov
2013-07-30 6:11 ` Masami Hiramatsu
2013-07-31 16:50 ` Steven Rostedt
2013-07-31 17:16 ` Steven Rostedt
2013-07-31 16:51 ` [PATCH v2 0/1] " Steven Rostedt
2013-07-31 17:38 ` Oleg Nesterov
2013-07-31 17:59 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130729175008.GA26284@redhat.com \
--to=oleg@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=azl@google.com \
--cc=dhsharp@google.com \
--cc=fweisbec@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jovi.zhangwei@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=vnagarnaik@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox