public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sarah Sharp <sarah.a.sharp@linux.intel.com>
To: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org
Subject: Checkpatch error on trace events macros
Date: Mon, 29 Jul 2013 12:52:01 -0700	[thread overview]
Message-ID: <20130729195201.GC14883@xanatos> (raw)

Hi Andy and Joe,

Checkpatch is complaining when code adds new trace events macros:

sarah@xanatos:~/git/kernels/xhci$ git am -s ~/Maildir.fetchmail/.to-apply
Applying: xhci: add traces for debug messages in xhci_address_device()
ERROR: Macros with complex values should be enclosed in parenthesis
#86: FILE: drivers/usb/host/xhci-trace.h:15:
+#define TRACE_SYSTEM xhci-hcd

ERROR: Macros with complex values should be enclosed in parenthesis
#115: FILE: drivers/usb/host/xhci-trace.h:44:
+#define TRACE_INCLUDE_PATH .

ERROR: Macros with complex values should be enclosed in parenthesis
#118: FILE: drivers/usb/host/xhci-trace.h:47:
+#define TRACE_INCLUDE_FILE xhci-trace

total: 3 errors, 0 warnings, 169 lines checked


The macros have to be defined that way for trace events to work.
Can you fix checkpatch not to complain about trace event macros?

Thanks,
Sarah Sharp

             reply	other threads:[~2013-07-29 19:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-29 19:52 Sarah Sharp [this message]
2013-07-29 20:02 ` Checkpatch error on trace events macros Joe Perches
2013-07-29 21:23   ` Sarah Sharp
2013-07-29 21:48     ` Joe Perches
2013-07-30  1:30 ` Li Zefan
2013-07-30  1:58   ` Joe Perches
2013-07-30  2:06     ` Li Zefan
2013-07-30  2:36       ` Joe Perches
2013-07-30  3:04         ` Li Zefan
2013-07-30  3:10           ` Joe Perches
2013-07-30  3:25             ` Li Zefan
2013-07-30 18:17               ` [PATCH] checkpatch: Ignore #define TRACE_<foo> macros Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130729195201.GC14883@xanatos \
    --to=sarah.a.sharp@linux.intel.com \
    --cc=apw@canonical.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox