From: Dave Jones <davej@redhat.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: daniel.vetter@ffwll.ch, airlied@redhat.com
Subject: Re: drm/crtc-helper: explicit DPMS on after modeset
Date: Mon, 29 Jul 2013 20:27:55 -0400 [thread overview]
Message-ID: <20130730002755.GB3853@redhat.com> (raw)
In-Reply-To: <20130723230814.8DE656601B0@gitolite.kernel.org>
On Tue, Jul 23, 2013 at 11:08:14PM +0000, Linux Kernel wrote:
> Gitweb: http://git.kernel.org/linus/;a=commit;h=25f397a429dfa43f22c278d0119a60a343aa568f
> Commit: 25f397a429dfa43f22c278d0119a60a343aa568f
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> AuthorDate: Fri Jul 19 18:57:11 2013 +0200
> Committer: Dave Airlie <airlied@redhat.com>
> CommitDate: Mon Jul 22 09:55:17 2013 +1000
>
> drm/crtc-helper: explicit DPMS on after modeset
> --- a/drivers/gpu/drm/drm_crtc_helper.c
> +++ b/drivers/gpu/drm/drm_crtc_helper.c
> @@ -677,6 +677,11 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set)
> /* don't break so fail path works correct */
> fail = 1;
> break;
> +
> + if (connector->dpms != DRM_MODE_DPMS_ON) {
> + DRM_DEBUG_KMS("connector dpms not on, full mode switch\n");
> + mode_changed = true;
> + }
> }
This code will never get executed. (See the break above it).
Dave
parent reply other threads:[~2013-07-30 0:28 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20130723230814.8DE656601B0@gitolite.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730002755.GB3853@redhat.com \
--to=davej@redhat.com \
--cc=airlied@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox