From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
george.cherian@ti.com,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 1/4] usb: phy: rename nop_usb_xceiv => usb_phy_gen_xceiv
Date: Tue, 30 Jul 2013 00:08:14 -0700 [thread overview]
Message-ID: <20130730070814.GF7656@atomide.com> (raw)
In-Reply-To: <20130729122022.GF24801@radagast>
* Felipe Balbi <balbi@ti.com> [130729 05:27]:
> On Fri, Jul 26, 2013 at 10:15:54PM +0200, Sebastian Andrzej Siewior wrote:
> > The "nop" driver isn't a do-nothing-stub but supports a couple functions
> > like clock on/off or is able to use a voltage regulator. This patch
> > simply renames the driver to "generic" since it is easy possible to
> > extend it by a simple function istead of writing a complete driver.
> >
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
> to me, this is great but I need Tony's Ack for it. Let's Cc Tony and
> linux-omap
Looking at this patch there's a pretty high probability of introducing
pointless merge conflicts.
How about do the platform data related changes as a separate follow-up
series? You can typically do this by keeping the old features around,
then doing a separate series to rename or remove the users later on.
This will remove the dependency between platform data and the driver
changes.
Regards,
Tony
next prev parent reply other threads:[~2013-07-30 7:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 20:15 am335x: support for multiple USB instances Sebastian Andrzej Siewior
2013-07-26 20:15 ` [PATCH 1/4] usb: phy: rename nop_usb_xceiv => usb_phy_gen_xceiv Sebastian Andrzej Siewior
2013-07-29 12:20 ` Felipe Balbi
2013-07-30 7:08 ` Tony Lindgren [this message]
2013-07-30 7:34 ` Sebastian Andrzej Siewior
2013-07-30 7:56 ` Tony Lindgren
2013-07-30 9:57 ` Sebastian Andrzej Siewior
2013-07-26 20:15 ` [PATCH 2/4] usb: phy: add am335x pieces to generic phy Sebastian Andrzej Siewior
2013-07-29 12:22 ` Felipe Balbi
2013-07-29 15:58 ` Sebastian Andrzej Siewior
2013-07-26 20:15 ` [PATCH 3/4] usb: musb: dsps: remove the hardcoded phy pieces Sebastian Andrzej Siewior
2013-07-26 20:15 ` [PATCH 4/4] usb: musb: dsps: use proper child nodes Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730070814.GF7656@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=george.cherian@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox