Re: [for-next-3.11][PATCH 0/8] ftrace/tracing: Event file fixes and ftrace function hash fixes

Oleg Nesterov
2013-07-31T14:28:01Z

On 07/31, Steven Rostedt wrote:
>
> On Wed, 2013-07-31 at 13:47 +0200, Oleg Nesterov wrote:
> > On 07/30, Steven Rostedt wrote:
> > >
> > > Using the i_private and event_mutex
> > > to verify that the event still exists to solve the race.
> >
> > To remind, we also need the "debugfs: debugfs_remove_recursive() must
> > not rely on list_empty(d_subdirs)" patch, otherwise we still have the
> > problems with the opened files.
>
> Do these patches depend on that patch?

No,

> Should I rebase to have that
> patch first?

And no.

That patch fixes the buggy debugfs_remove_recursive() and nothing else.

The test-case from the changelog can trigger the problem with or without
the recent changes. You can't (I hope) crash the kernel this way after
these changes, but the undeleted directory is still obviously bad.

Just I think that "open/delete fixes" is not complete without this fix.

Oleg.