From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756257Ab3G3OXF (ORCPT ); Tue, 30 Jul 2013 10:23:05 -0400 Received: from mail-qc0-f182.google.com ([209.85.216.182]:39779 "EHLO mail-qc0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754518Ab3G3OXD (ORCPT ); Tue, 30 Jul 2013 10:23:03 -0400 Date: Tue, 30 Jul 2013 10:22:59 -0400 From: Tejun Heo To: Li Zefan Cc: Andrew Morton , Glauber Costa , KAMEZAWA Hiroyuki , Michal Hocko , Johannes Weiner , LKML , Cgroups , linux-mm@kvack.org Subject: Re: [PATCH v3 2/8] cgroup: document how cgroup IDs are assigned Message-ID: <20130730142252.GJ12016@htj.dyndns.org> References: <51F614B2.6010503@huawei.com> <51F614D4.6000703@huawei.com> <20130729182632.GC26076@mtj.dyndns.org> <51F711FE.3040006@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51F711FE.3040006@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 30, 2013 at 09:08:14AM +0800, Li Zefan wrote: > On 2013/7/30 2:26, Tejun Heo wrote: > > On Mon, Jul 29, 2013 at 03:08:04PM +0800, Li Zefan wrote: > >> As cgroup id has been used in netprio cgroup and will be used in memcg, > >> it's important to make it clear how a cgroup id is allocated. > >> > >> For example, in netprio cgroup, the id is used as index of anarray. > >> > >> Signed-off-by: Li Zefan > >> Reviewed-by: Michal Hocko > > > > We can merge this into the first patch? > > > > The first patch just changes ida to idr, it doesn't change how IDs are > allocated, so I prefer make this a standalone patch. Hmmm... I'd just add "while at it, add a comment explaining ..." to the description and fold it into the prev patch but no biggie. Please do as you see fit. Thanks. -- tejun