From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org, laijs@cn.fujitsu.com,
shli@kernel.org, linux1394-devel@lists.sourceforge.net
Subject: Re: [PATCH 4/9] firewire: WQ_NON_REENTRANT is meaningless and going away
Date: Tue, 30 Jul 2013 15:52:17 +0200 [thread overview]
Message-ID: <20130730155217.4e5bcbf0@stein> (raw)
In-Reply-To: <1375188028-11910-5-git-send-email-tj@kernel.org>
On Jul 30 Tejun Heo wrote:
> Please route this through the subsystem tree. As written in the
> description, this shouldn't make any functional difference and just
> prepares for the removal of WQ_NON_REENTRANT which is already noop.
Committed to linux1394.git and pushed out to the for-next branch.
> ------ 8< -------
> dbf2576e37 ("workqueue: make all workqueues non-reentrant") made
> WQ_NON_REENTRANT no-op and the flag is going away. Remove its usages.
>
> This patch doesn't introduce any behavior changes.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>
> Cc: linux1394-devel@lists.sourceforge.net
> ---
> drivers/firewire/core-transaction.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/firewire/core-transaction.c b/drivers/firewire/core-transaction.c
> index 28a94c7..e5af0e3 100644
> --- a/drivers/firewire/core-transaction.c
> +++ b/drivers/firewire/core-transaction.c
> @@ -1262,8 +1262,7 @@ static int __init fw_core_init(void)
> {
> int ret;
>
> - fw_workqueue = alloc_workqueue("firewire",
> - WQ_NON_REENTRANT | WQ_MEM_RECLAIM, 0);
> + fw_workqueue = alloc_workqueue("firewire", WQ_MEM_RECLAIM, 0);
> if (!fw_workqueue)
> return -ENOMEM;
>
--
Stefan Richter
-=====-===-= -=== ====-
http://arcgraph.de/sr/
next prev parent reply other threads:[~2013-07-30 13:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 12:40 [PATCHSET wq/for-3.12] workqueue: WQ_NON_REENTRANT is meaningless and going away Tejun Heo
2013-07-30 12:40 ` [PATCH 1/9] workqueue: mark WQ_NON_REENTRANT deprecated Tejun Heo
2013-07-31 6:12 ` Lai Jiangshan
2013-07-30 12:40 ` [PATCH 2/9] dm: WQ_NON_REENTRANT is meaningless and going away Tejun Heo
2013-07-30 12:40 ` [PATCH 3/9] mmc: " Tejun Heo
2013-07-30 12:40 ` [PATCH 4/9] firewire: " Tejun Heo
2013-07-30 13:52 ` Stefan Richter [this message]
2013-07-30 12:40 ` [PATCH 5/9] dlm: " Tejun Heo
2013-07-30 12:40 ` [PATCH 6/9] gfs2: " Tejun Heo
2013-07-30 14:10 ` Steven Whitehouse
2013-07-30 12:40 ` [PATCH 7/9] xfs: " Tejun Heo
2013-07-30 18:13 ` Ben Myers
2013-07-30 12:40 ` [PATCH 8/9] ceph: " Tejun Heo
2013-07-30 12:40 ` [PATCH 9/9] l2tp: " Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730155217.4e5bcbf0@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=shli@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox