From: Dave Jones <davej@redhat.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
daniel.vetter@ffwll.ch, airlied@redhat.com,
Ben Widawsky <ben@bwidawsk.net>
Subject: Re: i915 debug spew during boot.
Date: Tue, 30 Jul 2013 15:38:06 -0400 [thread overview]
Message-ID: <20130730193805.GA11633@redhat.com> (raw)
In-Reply-To: <20130729210429.GB27041@cantiga.alporthouse.com>
On Mon, Jul 29, 2013 at 10:04:29PM +0100, Chris Wilson wrote:
> Whoops, we spotted that error and fixed it in the next tree, but forgot
> to send a fix for stable as well.
> ...
>
> +}
> +
> +void intel_pm_init(struct drm_device *dev)
> +{
> INIT_DELAYED_WORK(&dev_priv->rps.delayed_resume_work,
> intel_gen6_powersave_work);
> }
This doesn't compile.
LD drivers/gpu/drm/drm_kms_helper.o
LD drivers/gpu/drm/drm.o
CC drivers/gpu/drm/i915/intel_pm.o
drivers/gpu/drm/i915/intel_pm.c: In function ‘intel_pm_init’:
drivers/gpu/drm/i915/intel_pm.c:5543:70: error: ‘dev_priv’ undeclared (first use in this function)
INIT_DELAYED_WORK(&dev_priv->rps.delayed_resume_work,
^
drivers/gpu/drm/i915/intel_pm.c:5543:70: note: each undeclared identifier is reported only once for each function it appears in
make[4]: *** [drivers/gpu/drm/i915/intel_pm.o] Error 1
Needs this on top:
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 1235d71..f895d15 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -5540,6 +5540,8 @@ void intel_gt_init(struct drm_device *dev)
void intel_pm_init(struct drm_device *dev)
{
+ struct drm_i915_private *dev_priv = dev->dev_private;
+
INIT_DELAYED_WORK(&dev_priv->rps.delayed_resume_work,
intel_gen6_powersave_work);
}
prev parent reply other threads:[~2013-07-30 19:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 19:54 i915 debug spew during boot Dave Jones
2013-07-29 21:04 ` Chris Wilson
2013-07-29 21:15 ` Dave Jones
2013-07-30 19:38 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730193805.GA11633@redhat.com \
--to=davej@redhat.com \
--cc=airlied@redhat.com \
--cc=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox