From: Oleg Nesterov <oleg@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [for-next-3.11][PATCH 0/8] ftrace/tracing: Event file fixes and ftrace function hash fixes
Date: Wed, 31 Jul 2013 13:47:22 +0200 [thread overview]
Message-ID: <20130731114722.GA4416@redhat.com> (raw)
In-Reply-To: <20130730112718.273490378@goodmis.org>
On 07/30, Steven Rostedt wrote:
>
> Using the i_private and event_mutex
> to verify that the event still exists to solve the race.
To remind, we also need the "debugfs: debugfs_remove_recursive() must
not rely on list_empty(d_subdirs)" patch, otherwise we still have the
problems with the opened files.
Just in case, we need this fix even if .open() does trace_array_get()
or tracing_open_generic_file() (removed by recent changes), rmdir can
be called before we increment the counter and the deleted dentry breaks
debugfs_remove_recursive().
But after the recent changes this fix becomes more important. An opened
file confuses debugfs_remove_recursive() and after that you can't create
another probe.
Oleg.
next prev parent reply other threads:[~2013-07-31 11:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 11:27 [for-next-3.11][PATCH 0/8] ftrace/tracing: Event file fixes and ftrace function hash fixes Steven Rostedt
2013-07-30 11:27 ` [for-next-3.11][PATCH 1/8] tracing: Turn event/id->i_private into call->event.type Steven Rostedt
2013-07-30 11:27 ` [for-next-3.11][PATCH 2/8] tracing: Change event_enable/disable_read() to verify i_private != NULL Steven Rostedt
2013-07-30 11:27 ` [for-next-3.11][PATCH 3/8] tracing: Change event_filter_read/write " Steven Rostedt
2013-07-30 11:27 ` [for-next-3.11][PATCH 4/8] tracing: Change f_start() to take event_mutex and " Steven Rostedt
2013-07-30 11:27 ` [for-next-3.11][PATCH 5/8] tracing: Introduce remove_event_file_dir() Steven Rostedt
2013-07-30 11:27 ` [for-next-3.11][PATCH 6/8] tracing: Change remove_event_file_dir() to clear "d_subdirs"->i_private Steven Rostedt
2013-07-30 11:27 ` [for-next-3.11][PATCH 7/8] ftrace: Consolidate some duplicate code for updating ftrace ops Steven Rostedt
2013-07-30 11:27 ` [for-next-3.11][PATCH 8/8] ftrace: Clear module traced functions on unload module Steven Rostedt
2013-07-30 17:39 ` Steven Rostedt
2013-07-31 11:47 ` Oleg Nesterov [this message]
2013-07-31 14:06 ` [for-next-3.11][PATCH 0/8] ftrace/tracing: Event file fixes and ftrace function hash fixes Steven Rostedt
2013-07-31 14:22 ` Oleg Nesterov
2013-07-31 14:29 ` Oleg Nesterov
2013-07-31 16:43 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130731114722.GA4416@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox