From: Mark Brown <broonie@kernel.org>
To: Tejun Heo <htejun@gmail.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Peter Chen" <peter.chen@freescale.com>,
"Fabio Estevam" <festevam@gmail.com>,
alexander.shishkin@linux.intel.com, kernel@pengutronix.de,
linux-usb@vger.kernel.org,
"Fabio Estevam" <fabio.estevam@freescale.com>,
"Jeff Garzik" <jeff@garzik.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
"Mike Turquette" <mturquette@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] chipidea: Use devm_request_irq()
Date: Wed, 31 Jul 2013 14:27:08 +0100 [thread overview]
Message-ID: <20130731132708.GQ9858@sirena.org.uk> (raw)
In-Reply-To: <20130731115527.GR2810@htj.dyndns.org>
[-- Attachment #1: Type: text/plain, Size: 528 bytes --]
On Wed, Jul 31, 2013 at 07:55:27AM -0400, Tejun Heo wrote:
> If you have DMA / IRQ / command engine deactivations in devm path
> which often is the case with full conversions, freeing any resources
> including DMA areas and host private data in the wrong order is a
> horrible idea. It's worse as it won't really be noticeable in most
> cases.
It's really only interrupts that affect most devices - if there's DMA or
anything going on after the remove() then as you said earlier the driver
is probably doing something wrong.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-31 13:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1375232669-27846-1-git-send-email-festevam@gmail.com>
[not found] ` <1375232669-27846-2-git-send-email-festevam@gmail.com>
[not found] ` <20130731073306.GZ1754@pengutronix.de>
[not found] ` <20130731082054.GF8540@nchen-desktop>
[not found] ` <20130731084645.GB1754@pengutronix.de>
[not found] ` <20130731090512.GD9858@sirena.org.uk>
2013-07-31 9:44 ` [PATCH 2/2] chipidea: Use devm_request_irq() Uwe Kleine-König
2013-07-31 9:54 ` Tejun Heo
2013-07-31 10:28 ` Uwe Kleine-König
2013-07-31 10:41 ` Tejun Heo
2013-07-31 11:18 ` Mark Brown
2013-07-31 11:32 ` Tejun Heo
2013-07-31 11:50 ` Mark Brown
2013-07-31 11:55 ` Tejun Heo
2013-07-31 13:27 ` Mark Brown [this message]
2013-07-31 13:42 ` Tejun Heo
2013-07-31 13:57 ` Mark Brown
2013-07-31 14:07 ` Tejun Heo
2013-07-31 15:25 ` Mark Brown
2013-07-31 15:29 ` Tejun Heo
2013-07-31 16:52 ` Mark Brown
2013-07-31 13:55 ` Peter Chen
2013-07-31 14:15 ` Tejun Heo
2013-08-01 1:33 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130731132708.GQ9858@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=peter.chen@freescale.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox