From: Christoph Hellwig <hch@infradead.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [git pull] vfs.git, part 1
Date: Thu, 1 Aug 2013 02:00:46 -0700 [thread overview]
Message-ID: <20130801090046.GB21552@infradead.org> (raw)
In-Reply-To: <20130701195949.GI4165@ZenIV.linux.org.uk>
On Mon, Jul 01, 2013 at 08:59:49PM +0100, Al Viro wrote:
> The major change in that pile is ->readdir() replacement with ->iterate(),
> dealing with ->f_pos races in ->readdir() instances for good. There's
> a lot more, but I'd prefer to split the pull request into several stages
> and this is the first obvious cutoff point. Please, pull from the
> usual place -
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus
Again a little later, but iterate seems like a bad choice for a
directory specific operation in struct file operations, it really
should have "dir" somewhere in the method name.
next prev parent reply other threads:[~2013-08-01 9:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 19:59 [git pull] vfs.git, part 1 Al Viro
2013-08-01 9:00 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-02-17 17:15 [git pull] vfs.git " Al Viro
2016-07-28 15:55 Al Viro
2017-07-05 7:14 Al Viro
[not found] ` <87eftsv2hj.fsf@concordia.ellerman.id.au>
2017-07-07 15:59 ` Linus Torvalds
2017-07-07 16:30 ` Linus Torvalds
2017-07-07 22:55 ` Michael Ellerman
2017-07-07 17:35 ` Linus Torvalds
2017-07-07 18:59 ` Al Viro
2017-07-07 22:50 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801090046.GB21552@infradead.org \
--to=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).