From: Frederic Weisbecker <fweisbec@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 6/8] perf: Account freq events per cpu
Date: Thu, 1 Aug 2013 16:21:11 +0200 [thread overview]
Message-ID: <20130801142109.GH431@somewhere> (raw)
In-Reply-To: <20130801140615.GF27162@twins.programming.kicks-ass.net>
On Thu, Aug 01, 2013 at 04:06:15PM +0200, Peter Zijlstra wrote:
> On Thu, Aug 01, 2013 at 04:03:52PM +0200, Peter Zijlstra wrote:
> > On Thu, Aug 01, 2013 at 03:55:27PM +0200, Frederic Weisbecker wrote:
> > > On Thu, Aug 01, 2013 at 03:31:55PM +0200, Peter Zijlstra wrote:
> > > >
> > > > Where the freq thing is new and shiney, but we already had the other
> > > > two. Of those, cgroup events must be per cpu so that should be good,
> > > > the branch_stack thing tests ATTACH_TASK, which should also be good, but
> > > > leaves me wonder wth they do for those that are attached to tasks.
> > > >
> > > > But yes, the frequency thing is borken.
> > >
> > > Aie, so the freq thing, I can either account to all CPUs (inc to all
> > > and send an IPI to all), or when the event scheds in/out. Probably we
> > > should do the former to avoid sending an IPI at all context switches.
> >
> > Yeah, just go with a single global state for now..
>
> The perf default is to create inherited counter, which are per cpu
> anyway. So we'll not loose much.
So you mean that I keep the per cpu state when event->cpu != -1 and also have
a global counter for the others. Right?
next prev parent reply other threads:[~2013-08-01 14:21 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 0:30 [PATCH 0/8] perf: Finer grained full dynticks handling Frederic Weisbecker
2013-07-23 0:30 ` [PATCH 1/8] perf: Fix branch stack refcount leak on callchain init failure Frederic Weisbecker
2013-07-31 8:55 ` [tip:perf/core] " tip-bot for Frederic Weisbecker
2013-07-23 0:31 ` [PATCH 2/8] perf: Sanitize get_callchain_buffer() Frederic Weisbecker
2013-07-31 8:56 ` [tip:perf/core] " tip-bot for Frederic Weisbecker
2013-08-01 13:01 ` [PATCH 2/8] " Jiri Olsa
2013-08-01 13:28 ` Frederic Weisbecker
2013-08-01 13:32 ` Jiri Olsa
2013-08-01 13:49 ` Frederic Weisbecker
2013-08-01 13:54 ` Jiri Olsa
2013-08-01 13:57 ` Frederic Weisbecker
2013-08-01 13:29 ` Jiri Olsa
2013-08-01 13:42 ` Frederic Weisbecker
2013-08-01 13:51 ` Jiri Olsa
2013-08-01 14:30 ` Frederic Weisbecker
2013-07-23 0:31 ` [PATCH 3/8] perf: Gather event accounting code Frederic Weisbecker
2013-07-31 8:56 ` [tip:perf/core] perf: Factor out event accounting code to account_event()/__free_event() tip-bot for Frederic Weisbecker
2013-08-01 13:13 ` [PATCH 3/8] perf: Gather event accounting code Jiri Olsa
2013-08-01 13:30 ` Frederic Weisbecker
2013-07-23 0:31 ` [PATCH 4/8] perf: Split per cpu " Frederic Weisbecker
2013-07-31 8:56 ` [tip:perf/core] perf: Split the per-cpu accounting part of the " tip-bot for Frederic Weisbecker
2013-07-23 0:31 ` [PATCH 5/8] perf: Migrate per cpu event accounting Frederic Weisbecker
2013-07-31 8:56 ` [tip:perf/core] " tip-bot for Frederic Weisbecker
2013-07-23 0:31 ` [PATCH 6/8] perf: Account freq events per cpu Frederic Weisbecker
2013-07-31 8:56 ` [tip:perf/core] " tip-bot for Frederic Weisbecker
2013-08-01 12:46 ` [PATCH 6/8] " Jiri Olsa
2013-08-01 12:48 ` Jiri Olsa
2013-08-01 13:31 ` Peter Zijlstra
2013-08-01 13:35 ` Peter Zijlstra
2013-08-01 13:39 ` Jiri Olsa
2013-08-01 13:56 ` Peter Zijlstra
2013-08-01 13:55 ` Frederic Weisbecker
2013-08-01 14:03 ` Peter Zijlstra
2013-08-01 14:06 ` Peter Zijlstra
2013-08-01 14:21 ` Frederic Weisbecker [this message]
2013-08-01 14:40 ` Peter Zijlstra
2013-08-02 16:25 ` Frederic Weisbecker
2013-08-01 14:19 ` Frederic Weisbecker
2013-07-23 0:31 ` [PATCH 7/8] perf: Finer grained full dynticks kick Frederic Weisbecker
2013-07-31 8:56 ` [tip:perf/core] perf: Implement finer " tip-bot for Frederic Weisbecker
2013-07-23 0:31 ` [PATCH 8/8] watchdog: Remove hack to make full dynticks working Frederic Weisbecker
2013-07-23 12:33 ` Don Zickus
2013-07-23 12:44 ` Frederic Weisbecker
2013-07-23 12:45 ` Peter Zijlstra
2013-07-31 8:57 ` [tip:perf/core] watchdog: Make it work under full dynticks tip-bot for Frederic Weisbecker
2013-07-25 9:59 ` [PATCH 0/8] perf: Finer grained full dynticks handling Peter Zijlstra
2013-07-25 14:02 ` Frederic Weisbecker
2013-07-25 16:29 ` Peter Zijlstra
2013-07-25 20:07 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801142109.GH431@somewhere \
--to=fweisbec@gmail.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).