From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Seth Jennings <sjenning@linux.vnet.ibm.com>
Cc: Nathan Fontenot <nfont@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Nivedita Singhvi <niv@us.ibm.com>,
Michael J Wolf <mjwolf@us.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: base: new memory config sysfs driver for large memory systems
Date: Fri, 2 Aug 2013 04:57:58 +0800 [thread overview]
Message-ID: <20130801205758.GB13585@kroah.com> (raw)
In-Reply-To: <20130726143344.GA4379@variantweb.net>
On Fri, Jul 26, 2013 at 09:33:44AM -0500, Seth Jennings wrote:
> On Thu, Jul 25, 2013 at 04:38:00PM -0700, Greg Kroah-Hartman wrote:
> > On Thu, Jul 25, 2013 at 04:11:20PM -0500, Seth Jennings wrote:
> > > From: Nathan Fontenot <nfont@linux.vnet.ibm.com>
> > >
> > > Large memory systems (1TB or more) experience boot delays on the order
> > > of minutes due to the initializing the memory configuration part of
> > > sysfs at /sys/devices/system/memory/.
> > >
> > > ppc64 has a memory block size of 256M and (I think) x86 is 128M. With 1TB
> > > of RAM and a 256M block size, that's 4k memory blocks with 20 sysfs
> > > entries per block that's around 80k items that need be created at boot
> > > time in sysfs. Some systems go up to 16TB where the issue is
> > > even more severe.
> > >
> > > This patch is a prototype for a new sysfs memory layout where the
> > > entries are created on demand by writing memory block numbers into a
> > > "show" and "hide" files to create and destroy the memory block
> > > configuration attributes in sysfs. This would decouple the number of
> > > sysfs entries created at boot time from the memory size, resulting in a
> > > sysfs initialization time that doesn't increase and memory size
> > > increase.
> > >
> > > Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
> > > Signed-off-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
> >
> > How does this tie into the patches Nathan sent yesterday for memory
> > hotplug stuff that I thought modified the same part of the kernel?
>
> So this patch introduces the new layout in a new file
> drives/base/memfs.c (which, in light of your last comment should
> probably be something more like largememory.c).
>
> It doesn't clash with Nathan's, but it doesn't contain the new
> is_memblock_[removable|offline] functions or the new "release"
> attribute. But that can be added easily.
Can you two please work together on this so I we don't have to deal with
competing patch sets and get confused as to what is really going on
here?
thanks,
greg k-h
next prev parent reply other threads:[~2013-08-01 20:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1374786680-26197-1-git-send-email-sjenning@linux.vnet.ibm.com>
2013-07-25 23:38 ` [PATCH] drivers: base: new memory config sysfs driver for large memory systems Greg Kroah-Hartman
2013-07-26 14:33 ` Seth Jennings
2013-08-01 20:57 ` Greg Kroah-Hartman [this message]
2013-07-25 23:40 ` Greg Kroah-Hartman
2013-07-26 14:42 ` Seth Jennings
2013-08-01 20:57 ` Greg Kroah-Hartman
2013-08-01 22:13 ` Dave Hansen
2013-08-02 15:50 ` Seth Jennings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801205758.GB13585@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjwolf@us.ibm.com \
--cc=nfont@linux.vnet.ibm.com \
--cc=niv@us.ibm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox