public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Evan Ng <evan.sin.ng@gmail.com>
Cc: pe1dnn@amsat.org, johanmeiring@gmail.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: wlags49_h2: fixed 80 line character and white space issue in ap_h2.c Fixed various coding style warnings found by the checkpatch.pl tool
Date: Fri, 2 Aug 2013 05:50:19 +0800	[thread overview]
Message-ID: <20130801215019.GA4427@kroah.com> (raw)
In-Reply-To: <1375303465-3437-1-git-send-email-evan.sin.ng@gmail.com>

On Wed, Jul 31, 2013 at 01:44:25PM -0700, Evan Ng wrote:
> From: esn89 <evan.sin.ng@gmail.com>

I need a real name here, odds are "esn89" isn't yours :)

Also, look at the subject you created, it's not correct, you need to add
a newline after a short description, followed by the longer description,
for git to pick this up properly.

> Signed-off-by: Evan Ng <evan.sin.ng@gmail.com>
> ---
>  drivers/staging/wlags49_h2/ap_h2.c | 7884 +++++++++++++++++++++---------------
>  1 file changed, 4668 insertions(+), 3216 deletions(-)

That's almos impossible to review, can you do "one thing at a time" so
that we can review it?  Break it up into lots of different pieces and
send a series of patches.

thanks,

greg k-h

       reply	other threads:[~2013-08-01 21:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1375303465-3437-1-git-send-email-evan.sin.ng@gmail.com>
2013-08-01 21:50 ` Greg KH [this message]
     [not found]   ` <CAGkkOHezKfjYaGJHcbPPiE4EobOLMp=K62-NWhpbvp2QDhLOfA@mail.gmail.com>
2013-08-01 22:28     ` [PATCH] Staging: wlags49_h2: fixed 80 line character and white space issue in ap_h2.c Fixed various coding style warnings found by the checkpatch.pl tool Greg KH
2013-08-01 23:48       ` Joe Perches
2013-08-02 10:37   ` Dan Carpenter
2013-08-02 19:39 ` Evan Ng
2013-08-04 15:43   ` Henk de Groot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130801215019.GA4427@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=evan.sin.ng@gmail.com \
    --cc=johanmeiring@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pe1dnn@amsat.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox