From: Felipe Balbi <balbi@ti.com>
To: Boris BREZILLON <b.brezillon@overkiz.com>
Cc: Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Ludovic Desroches <ludovic.desroches@atmel.com>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] usb: gadget: at91_udc: add usb_clk for transition to common clk framework
Date: Fri, 2 Aug 2013 10:46:57 +0300 [thread overview]
Message-ID: <20130802074657.GI24465@radagast> (raw)
In-Reply-To: <1375376870-22747-1-git-send-email-b.brezillon@overkiz.com>
[-- Attachment #1: Type: text/plain, Size: 481 bytes --]
Hi,
On Thu, Aug 01, 2013 at 07:07:50PM +0200, Boris BREZILLON wrote:
> @@ -1851,6 +1860,12 @@ fail3:
> fail2:
> free_irq(udc->udp_irq, udc);
> fail1:
> + if (IS_ENABLED(CONFIG_COMMON_CLK) && !IS_ERR(udc->uclk))
> + clk_put(udc->uclk);
> + if (!IS_ERR(udc->fclk))
> + clk_put(udc->fclk);
> + if (!IS_ERR(udc->iclk))
> + clk_put(udc->iclk);
adding missing clk_put() for iclk and fclk should be part of a separate
patch. Please split this part.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-08-02 7:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 17:07 [PATCH v2] usb: gadget: at91_udc: add usb_clk for transition to common clk framework Boris BREZILLON
2013-08-02 7:46 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130802074657.GI24465@radagast \
--to=balbi@ti.com \
--cc=b.brezillon@overkiz.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox