From: Wolfram Sang <wsa@the-dreams.de>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: rtc-stmp3xxx: provide timeout for potentially endless loop polling a HW bit
Date: Fri, 2 Aug 2013 10:06:07 +0200 [thread overview]
Message-ID: <20130802080607.GA2992@katana> (raw)
In-Reply-To: <1375280941-22657-1-git-send-email-LW@KARO-electronics.de>
[-- Attachment #1: Type: text/plain, Size: 511 bytes --]
On Wed, Jul 31, 2013 at 04:29:01PM +0200, Lothar Waßmann wrote:
> It's always a bad idea to poll on HW bits without a timeout.
>
> The i.MX28 RTC can be easily brought into a state in which the RTC is
> not running (until after a power-on-reset) and thus the status bits
> which are polled in the driver won't ever change.
>
> This patch prevents the kernel from getting stuck in this case.
>
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-08-02 8:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 14:29 [PATCH] rtc: rtc-stmp3xxx: provide timeout for potentially endless loop polling a HW bit Lothar Waßmann
2013-08-02 8:06 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130802080607.GA2992@katana \
--to=wsa@the-dreams.de \
--cc=LW@KARO-electronics.de \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox