From: Lee Jones <lee.jones@linaro.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Samuel Ortiz'" <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, linus.walleij@linaro.org
Subject: Re: [PATCH 2/2] mfd: ab8500-gpadc: add CONFIG_PM_SLEEP to suspend/resume
Date: Fri, 2 Aug 2013 11:16:44 +0100 [thread overview]
Message-ID: <20130802101644.GC17368@lee--X1> (raw)
In-Reply-To: <000201ce8f40$2322df90$69689eb0$@samsung.com>
On Fri, 02 Aug 2013, Jingoo Han wrote:
> Add CONFIG_PM_SLEEP to suspend/resume functions to fix the build
> warnings when CONFIG_PM_SLEEP is not selected. This is because
> sleep PM callbacks defined by SET_SYSTEM_SLEEP_PM_OPS are only used
> when the CONFIG_PM_SLEEP is enabled.
>
> drivers/mfd/ab8500-gpadc.c:891:12: warning: 'ab8500_gpadc_suspend' defined but not used [-Wunused-function]
> drivers/mfd/ab8500-gpadc.c:903:12: warning: 'ab8500_gpadc_resume' defined but not used [-Wunused-function]
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/mfd/ab8500-gpadc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c
> index 77c616f..36000f9 100644
> --- a/drivers/mfd/ab8500-gpadc.c
> +++ b/drivers/mfd/ab8500-gpadc.c
> @@ -888,6 +888,7 @@ static int ab8500_gpadc_runtime_resume(struct device *dev)
> }
> #endif
>
> +#ifdef CONFIG_PM_SLEEP
> static int ab8500_gpadc_suspend(struct device *dev)
> {
> struct ab8500_gpadc *gpadc = dev_get_drvdata(dev);
> @@ -915,6 +916,7 @@ static int ab8500_gpadc_resume(struct device *dev)
> mutex_unlock(&gpadc->ab8500_gpadc_lock);
> return ret;
> }
> +#endif
>
> static int ab8500_gpadc_probe(struct platform_device *pdev)
> {
Looks sensible. I wonder why we haven't caught these before.
I guess we always enable PM_SLEEP.
Applied until Linus tells me otherwise.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-08-02 10:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 5:21 [PATCH 2/2] mfd: ab8500-gpadc: add CONFIG_PM_SLEEP to suspend/resume Jingoo Han
2013-08-02 10:16 ` Lee Jones [this message]
2013-08-14 16:45 ` Linus Walleij
2013-08-14 18:00 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130802101644.GC17368@lee--X1 \
--to=lee.jones@linaro.org \
--cc=jg1.han@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox