* [PATCH 1/2] mfd: ab8500-gpadc: add CONFIG_PM_RUNTIME to runtime_suspend/runtime_resume
@ 2013-08-02 5:20 Jingoo Han
2013-08-02 10:17 ` Lee Jones
2013-08-14 16:45 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Jingoo Han @ 2013-08-02 5:20 UTC (permalink / raw)
To: Samuel Ortiz, Lee Jones; +Cc: linux-kernel, Jingoo Han
Add CONFIG_PM_RUNTIME to runtime_suspend/runtime_resume functions
to fix the build warnings when CONFIG_PM_RUNTIME is not selected.
This is because runtime PM callbacks defined by SET_RUNTIME_PM_OPS
are only used when the CONFIG_PM_RUNTIME is enabled.
drivers/mfd/ab8500-gpadc.c:870:12: warning: 'ab8500_gpadc_runtime_suspend' defined but not used [-Wunused-function]
drivers/mfd/ab8500-gpadc.c:878:12: warning: 'ab8500_gpadc_runtime_resume' defined but not used [-Wunused-function]
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mfd/ab8500-gpadc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c
index 7623e91..77c616f 100644
--- a/drivers/mfd/ab8500-gpadc.c
+++ b/drivers/mfd/ab8500-gpadc.c
@@ -867,6 +867,7 @@ static void ab8500_gpadc_read_calibration_data(struct ab8500_gpadc *gpadc)
gpadc->cal_data[ADC_INPUT_VBAT].offset);
}
+#ifdef CONFIG_PM_RUNTIME
static int ab8500_gpadc_runtime_suspend(struct device *dev)
{
struct ab8500_gpadc *gpadc = dev_get_drvdata(dev);
@@ -885,6 +886,7 @@ static int ab8500_gpadc_runtime_resume(struct device *dev)
dev_err(dev, "Failed to enable vtvout LDO: %d\n", ret);
return ret;
}
+#endif
static int ab8500_gpadc_suspend(struct device *dev)
{
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] mfd: ab8500-gpadc: add CONFIG_PM_RUNTIME to runtime_suspend/runtime_resume
2013-08-02 5:20 [PATCH 1/2] mfd: ab8500-gpadc: add CONFIG_PM_RUNTIME to runtime_suspend/runtime_resume Jingoo Han
@ 2013-08-02 10:17 ` Lee Jones
2013-08-14 16:45 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Lee Jones @ 2013-08-02 10:17 UTC (permalink / raw)
To: Jingoo Han; +Cc: Samuel Ortiz, linux-kernel, linus.walleij
On Fri, 02 Aug 2013, Jingoo Han wrote:
> Add CONFIG_PM_RUNTIME to runtime_suspend/runtime_resume functions
> to fix the build warnings when CONFIG_PM_RUNTIME is not selected.
> This is because runtime PM callbacks defined by SET_RUNTIME_PM_OPS
> are only used when the CONFIG_PM_RUNTIME is enabled.
>
> drivers/mfd/ab8500-gpadc.c:870:12: warning: 'ab8500_gpadc_runtime_suspend' defined but not used [-Wunused-function]
> drivers/mfd/ab8500-gpadc.c:878:12: warning: 'ab8500_gpadc_runtime_resume' defined but not used [-Wunused-function]
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/mfd/ab8500-gpadc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c
> index 7623e91..77c616f 100644
> --- a/drivers/mfd/ab8500-gpadc.c
> +++ b/drivers/mfd/ab8500-gpadc.c
> @@ -867,6 +867,7 @@ static void ab8500_gpadc_read_calibration_data(struct ab8500_gpadc *gpadc)
> gpadc->cal_data[ADC_INPUT_VBAT].offset);
> }
>
> +#ifdef CONFIG_PM_RUNTIME
> static int ab8500_gpadc_runtime_suspend(struct device *dev)
> {
> struct ab8500_gpadc *gpadc = dev_get_drvdata(dev);
> @@ -885,6 +886,7 @@ static int ab8500_gpadc_runtime_resume(struct device *dev)
> dev_err(dev, "Failed to enable vtvout LDO: %d\n", ret);
> return ret;
> }
> +#endif
>
> static int ab8500_gpadc_suspend(struct device *dev)
> {
Looks sensible. I wonder why we haven't caught these before.
I guess we always enable PM_SLEEP.
Applied until Linus tells me otherwise.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] mfd: ab8500-gpadc: add CONFIG_PM_RUNTIME to runtime_suspend/runtime_resume
2013-08-02 5:20 [PATCH 1/2] mfd: ab8500-gpadc: add CONFIG_PM_RUNTIME to runtime_suspend/runtime_resume Jingoo Han
2013-08-02 10:17 ` Lee Jones
@ 2013-08-14 16:45 ` Linus Walleij
2013-08-14 18:00 ` Lee Jones
1 sibling, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2013-08-14 16:45 UTC (permalink / raw)
To: Jingoo Han; +Cc: Samuel Ortiz, Lee Jones, linux-kernel@vger.kernel.org
On Fri, Aug 2, 2013 at 7:20 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> Add CONFIG_PM_RUNTIME to runtime_suspend/runtime_resume functions
> to fix the build warnings when CONFIG_PM_RUNTIME is not selected.
> This is because runtime PM callbacks defined by SET_RUNTIME_PM_OPS
> are only used when the CONFIG_PM_RUNTIME is enabled.
>
> drivers/mfd/ab8500-gpadc.c:870:12: warning: 'ab8500_gpadc_runtime_suspend' defined but not used [-Wunused-function]
> drivers/mfd/ab8500-gpadc.c:878:12: warning: 'ab8500_gpadc_runtime_resume' defined but not used [-Wunused-function]
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] mfd: ab8500-gpadc: add CONFIG_PM_RUNTIME to runtime_suspend/runtime_resume
2013-08-14 16:45 ` Linus Walleij
@ 2013-08-14 18:00 ` Lee Jones
0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2013-08-14 18:00 UTC (permalink / raw)
To: Linus Walleij; +Cc: Jingoo Han, Samuel Ortiz, linux-kernel@vger.kernel.org
On Wed, 14 Aug 2013, Linus Walleij wrote:
> On Fri, Aug 2, 2013 at 7:20 AM, Jingoo Han <jg1.han@samsung.com> wrote:
>
> > Add CONFIG_PM_RUNTIME to runtime_suspend/runtime_resume functions
> > to fix the build warnings when CONFIG_PM_RUNTIME is not selected.
> > This is because runtime PM callbacks defined by SET_RUNTIME_PM_OPS
> > are only used when the CONFIG_PM_RUNTIME is enabled.
> >
> > drivers/mfd/ab8500-gpadc.c:870:12: warning: 'ab8500_gpadc_runtime_suspend' defined but not used [-Wunused-function]
> > drivers/mfd/ab8500-gpadc.c:878:12: warning: 'ab8500_gpadc_runtime_resume' defined but not used [-Wunused-function]
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Applied the Ack.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-14 18:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-02 5:20 [PATCH 1/2] mfd: ab8500-gpadc: add CONFIG_PM_RUNTIME to runtime_suspend/runtime_resume Jingoo Han
2013-08-02 10:17 ` Lee Jones
2013-08-14 16:45 ` Linus Walleij
2013-08-14 18:00 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox