Re: [PATCH 2/4] mm, migrate: allocation new page lazyily in unmap_and_move()

Joonsoo Kim
2013-08-05T07:40:52Z

> get_new_page() sets up result to communicate error codes from the
> following checks. While the existing ones (page freed and thp split
> failed) don't change rc, somebody else might add a condition whose
> error code should be propagated back into *result but miss it.
>
> Please leave get_new_page() where it is. The win from this change is
> not big enough to risk these problems.

Hello, Johannes.

Okay. You are right. I will omit this patch next time.

Thanks.