Re: [RFC v01 0/3] Power Capping Framework

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Aug 02, 2013 at 11:08:49AM -0700, Srinivas Pandruvada wrote:
> - A uniform sys-fs interface for all devices which can offer power capping

There is no "-" in sysfs please.

> - A common API for drivers, which will avoid code duplication and easy
> implementation of client drivers.
> 
> Once this framework is approved, we will submit a RAPL client driver using this
> framework.

No, you need users of a framework in order for it to be approved, we
don't add infrastructure without users.

Especially as what usually happens is, when you add actual users, the
framework changes to fix the bugs found in it :)

Ideally you will have more than one client driver submitted, as a
"framework" for just one driver seems a bit odd, don't you think?

Also, you add lots of new sysfs files, those need to be documented in
Documentation/ABI/ with this series.

thanks,

greg k-h