public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>,
	linux-kernel@vger.kernel.org, acme@infradead.org,
	Andi Kleen <ak@linux.intel.com>,
	Namhyung Kim <namhyung.kim@lge.com>,
	peterz@infradead.org
Subject: Re: [PATCH] RFC: perf, tools: Move gtk browser into separate perfgtk executable
Date: Mon, 5 Aug 2013 11:08:57 +0200	[thread overview]
Message-ID: <20130805090857.GA26940@gmail.com> (raw)
In-Reply-To: <20130805083434.GA20606@infradead.org>


* Christoph Hellwig <hch@infradead.org> wrote:

> On Mon, Aug 05, 2013 at 10:31:32AM +0200, Ingo Molnar wrote:
>
> > Nonsense, a distro, if it truly worried about this, could create two 
> > packages already, there's no need to expose configuration options in 
> > the binary name itself and burden users with the separation. I 
> > sometimes switch the UI frontend of perf depending on the workflow and 
> > the terminal, it would be highly annoying if the binary name was 
> > changed to expose configuration options.
> 
> Which means you'd have to use a different tool name or have incompatible 
> packages, both of which aren't desirable.

You'd have alternative packages - i.e. the configuration and dependency 
difference is exposed in the packaging space, not in the user interface, 
command name space.

(and yes, gtk linking in 20+ libraries is suboptimal, hopefully that will 
eventually be fixed by the GTK project. If a leaner project with similarly 
good UI elements comes around we might switch to it - without having to 
rename the binary yet again.)

I.e. put the burden on packagers for too high library dependency 
complexity, not on end users. A fair deal by any count.

> > The thing is, you strongly objected to perf itself when we offered it 
> > up for an upstream merge and I'm not surprised you still don't like 
> > it.
> 
> I strongly objected to adding it to the kernel tree, and I still stand 
> to that opinion because it makes using perf much more painful than it 
> needs to be. [...]

That's still a red herring - 'using' perf for 99% of the users is to 
install the perf package or to type 'make install' ...

> [...]  I never disliked perf itself and use it frequently now that I can 
> bypass some of the pains by just using an older distro package.

If you have special needs you could lobby your distro for different 
versions - or you could build it from source.

Your solution, to split the binary into two parts, just to expose a 
configuration option you don't want to enable in certain uses, burdens the 
regular user of perf.

> But I'd much rather get this back to technical discussions than personal 
> attacks..

You never replied to the original counter-arguments, such as this one from 
Linus:

  http://article.gmane.org/gmane.linux.kernel/849965

Or this one from Andrew:

  http://article.gmane.org/gmane.linux.kernel/850067

so I assumed your (still arguably dishonest) objections are still valid 
and still broad - and are reflected in this thread.

That's not a personal attack by any means - we met before and I actually 
like you as a person, I just don't like your opinion here and I don't like 
your occasionally dishonest discussion style: because it only focuses on 
the narrow issue of packaging complexity and does not look at the bigger 
picture such as health of development and end user ease of use.

Thanks,

	Ingo

  reply	other threads:[~2013-08-05  9:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-05  2:22 [PATCH] RFC: perf, tools: Move gtk browser into separate perfgtk executable Andi Kleen
2013-08-05  8:16 ` Ingo Molnar
2013-08-05  8:23   ` Christoph Hellwig
2013-08-05  8:31     ` Ingo Molnar
2013-08-05  8:34       ` Christoph Hellwig
2013-08-05  9:08         ` Ingo Molnar [this message]
2013-08-06  6:19           ` Christoph Hellwig
2013-08-12 18:19             ` Ingo Molnar
2013-08-12 19:25               ` Vince Weaver
2013-08-13 10:48                 ` Ingo Molnar
2013-08-13 12:11                   ` Arnaldo Carvalho de Melo
2013-08-13 16:00                     ` Ingo Molnar
2013-08-13 21:57                       ` Vince Weaver
2013-08-13 22:17                         ` Andi Kleen
2013-08-14 14:13                         ` Arnaldo Carvalho de Melo
2013-08-14 14:20                           ` Ingo Molnar
2013-08-13 14:03                   ` Vince Weaver
2013-08-13 16:04                     ` Ingo Molnar
2013-08-05  9:08     ` Namhyung Kim
2013-08-05  9:12       ` Ingo Molnar
2013-08-05  9:18         ` Pekka Enberg
2013-08-05 19:10       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130805090857.GA26940@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@infradead.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox