From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andy Lutomirski <luto@mit.edu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: O_TMPFILE fs corruption (Re: Linux 3.11-rc4)
Date: Mon, 5 Aug 2013 15:31:50 +0100 [thread overview]
Message-ID: <20130805143149.GA27005@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+55aFw9AY2GLC3xieuy7jgFwsUePJ+kety-AHqFxkP1pPUAVw@mail.gmail.com>
On Sun, Aug 04, 2013 at 08:45:16PM -0700, Linus Torvalds wrote:
> The patch looks right to me - we should pass in similar flags for the
> create case as for tmpfile to the filesystem.
>
> But let's make sure we're all on the same page. Al?
ACK. It used to happen as a side effect of O_CREAT being required
in the flags, but that broke once we switched to use of O_DIRECTORY.
I've applied both Andi's patches (along with one from Zheng Liu) in
vfs.git #for-linus. Another thing in there is reiserfs umount
deadlock fix - that one needs to go in all branches starting from
2.6.23.
Please, pull from the usual place -
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus
Shortlog:
Al Viro (1):
reiserfs: fix deadlock in umount
Andy Lutomirski (2):
fs: Fix file mode for O_TMPFILE
fs: Allow unprivileged linkat(..., AT_EMPTY_PATH) aka flink
Zheng Liu (1):
vfs: add missing check for __O_TMPFILE in fcntl_init()
Diffstat:
fs/fcntl.c | 4 +-
fs/namei.c | 10 ++----
fs/open.c | 2 +-
fs/reiserfs/procfs.c | 99 ++++++++++----------------------------------------
fs/reiserfs/super.c | 3 +-
5 files changed, 26 insertions(+), 92 deletions(-)
next prev parent reply other threads:[~2013-08-05 14:31 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-04 21:09 Linux 3.11-rc4 Linus Torvalds
2013-08-05 2:34 ` O_TMPFILE fs corruption (Re: Linux 3.11-rc4) Andy Lutomirski
2013-08-05 3:45 ` Linus Torvalds
2013-08-05 4:45 ` Andrew Lutomirski
2013-08-05 8:26 ` Christoph Hellwig
2013-08-05 16:04 ` Jörn Engel
2013-08-05 14:31 ` Al Viro [this message]
2013-08-05 4:20 ` Linux 3.11-rc4 Felipe Contreras
2013-08-05 13:29 ` Oleg Nesterov
2013-08-05 14:27 ` Felipe Contreras
2013-08-05 14:39 ` Oleg Nesterov
2013-08-05 17:02 ` Felipe Contreras
2013-08-05 17:11 ` Oleg Nesterov
2013-08-05 17:40 ` Felipe Contreras
2013-08-05 17:56 ` Oleg Nesterov
2013-08-05 17:39 ` Linus Torvalds
2013-08-05 17:43 ` Felipe Contreras
2013-08-05 18:08 ` Felipe Contreras
2013-08-05 17:47 ` Oleg Nesterov
2013-08-05 18:46 ` Oleg Nesterov
2013-08-05 18:54 ` Linus Torvalds
2013-08-05 18:57 ` Oleg Nesterov
2013-08-05 19:06 ` Linus Torvalds
2013-08-06 15:43 ` [PATCH 0/1] (Was: Linux 3.11-rc4) Oleg Nesterov
2013-08-06 15:43 ` [PATCH 1/1] Revert "ptrace: PTRACE_DETACH should do flush_ptrace_hw_breakpoint(child)" Oleg Nesterov
2013-08-07 12:05 ` [PATCH 0/1] (Was: Linux 3.11-rc4) Grazvydas Ignotas
2013-08-07 17:22 ` Oleg Nesterov
2013-08-07 19:26 ` Linus Torvalds
2013-08-07 19:27 ` Oleg Nesterov
2013-08-07 19:47 ` Linus Torvalds
2013-08-08 15:41 ` Oleg Nesterov
2013-08-08 16:25 ` Linus Torvalds
2013-08-08 16:54 ` Frederic Weisbecker
2013-08-08 18:15 ` Oleg Nesterov
2013-08-09 16:45 ` Frederic Weisbecker
2013-08-09 17:12 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130805143149.GA27005@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@mit.edu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox