From: Leif Lindholm <leif.lindholm@linaro.org>
To: Dave Martin <Dave.Martin@arm.com>
Cc: Roy Franz <roy.franz@linaro.org>,
linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, matt.fleming@intel.com,
linux@arm.linux.org.uk
Subject: Re: [PATCH 6/7] Add EFI stub for ARM
Date: Mon, 5 Aug 2013 17:33:19 +0200 [thread overview]
Message-ID: <20130805153318.GL18151@rocoto.smurfnet.nu> (raw)
In-Reply-To: <20130805141149.GB2755@localhost.localdomain>
On Mon, Aug 05, 2013 at 03:11:49PM +0100, Dave Martin wrote:
> > diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S
> > index 75189f1..4c70b9e 100644
> > --- a/arch/arm/boot/compressed/head.S
> > +++ b/arch/arm/boot/compressed/head.S
> > @@ -122,19 +122,106 @@
> > .arm @ Always enter in ARM state
> > start:
> > .type start,#function
> > - .rept 7
> > +#ifdef CONFIG_EFI_STUB
> > + @ Magic MSDOS signature for PE/COFF + ADD opcode
> > + .word 0x62805a4d
>
> What about BE32?
The ARM bindings for UEFI specify that the processor must be in
little-endian mode.
> In that case, the instruction is a coprocessor load, that loads from a
> random address to a coprocessor that almost certainly doesn't exist.
> This will probably fault.
>
> Since BE32 is only for older platforms (<v6) and this is not easily
> solvable, it might be sensible to make the EFI stub support depend on
> !CPU_ENDIAN_BE32.
Well, it would make more sense to make EFI_STUB depend on EFI and
EFI depend on !CPU_ENDIAN_BE32. Which is something I can add to
my next set of general ARM UEFI patches. Thanks.
/
Leif
next prev parent reply other threads:[~2013-08-05 15:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 21:29 [PATCH 0/7] RFC: EFI stub for ARM Roy Franz
2013-08-02 21:29 ` [PATCH 1/7] EFI stub documentation updates Roy Franz
2013-08-05 14:12 ` Dave Martin
2013-08-05 23:56 ` Roy Franz
2013-08-06 10:30 ` Dave P Martin
2013-08-02 21:29 ` [PATCH 2/7] Move common EFI stub code from x86 arch code to common location Roy Franz
2013-08-06 13:53 ` Matt Fleming
2013-08-02 21:29 ` [PATCH 3/7] Change EFI helper APIs to be more flexible Roy Franz
2013-08-06 13:53 ` Matt Fleming
2013-08-02 21:29 ` [PATCH 4/7] Add proper definitions for some EFI function pointers Roy Franz
2013-08-06 13:19 ` Matt Fleming
2013-08-02 21:29 ` [PATCH 5/7] Add strstr to compressed string.c for ARM Roy Franz
2013-08-02 21:29 ` [PATCH 6/7] Add EFI stub " Roy Franz
2013-08-05 14:11 ` Dave Martin
2013-08-05 15:33 ` Leif Lindholm [this message]
2013-08-06 0:06 ` Roy Franz
2013-08-06 10:40 ` Dave P Martin
2013-08-06 10:31 ` Dave P Martin
2013-08-06 3:35 ` Roy Franz
2013-08-02 21:29 ` [PATCH 7/7] Add config EFI_STUB " Roy Franz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130805153318.GL18151@rocoto.smurfnet.nu \
--to=leif.lindholm@linaro.org \
--cc=Dave.Martin@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=matt.fleming@intel.com \
--cc=roy.franz@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox