From: Oleg Nesterov <oleg@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 3.11-rc4
Date: Mon, 5 Aug 2013 20:57:12 +0200 [thread overview]
Message-ID: <20130805185712.GA12225@redhat.com> (raw)
In-Reply-To: <CA+55aFzWcOXfiJGzF1sVgZFaM_hRSF25P2kC2Ga_b0177jfjYA@mail.gmail.com>
On 08/05, Linus Torvalds wrote:
>
> On Mon, Aug 5, 2013 at 11:46 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > Heh. I pulled wine-git.
> >
> > set_thread_context() does a lot of PTRACE_POKEUSER requests and then
> > it calls resume_after_ptrace() which simply does PTRACE_DETACH.
> >
> > I'll recheck tomorrow, but it really looks as if it _wants_ to leak
> > the debug registers after detach. And more, it does PTRACE_ATTACH
> > only to set these regs.
> >
> > And this is exactly what fab840f tries to prevent.
>
> Ok, so I guess it's effectively the ABI, and we should just make the
> rule be that "if you don't want stale breakpoints, then remove the
> breakpoints when you detach".
I'm afraid yes.
> And thus reverting it the right thing to do. Agreed?
Yes, yes, sure. I'll write the changelog and send git-revert tomorrow,
unless you do it yourself.
Oleg.
next prev parent reply other threads:[~2013-08-05 19:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-04 21:09 Linux 3.11-rc4 Linus Torvalds
2013-08-05 2:34 ` O_TMPFILE fs corruption (Re: Linux 3.11-rc4) Andy Lutomirski
2013-08-05 3:45 ` Linus Torvalds
2013-08-05 4:45 ` Andrew Lutomirski
2013-08-05 8:26 ` Christoph Hellwig
2013-08-05 16:04 ` Jörn Engel
2013-08-05 14:31 ` Al Viro
2013-08-05 4:20 ` Linux 3.11-rc4 Felipe Contreras
2013-08-05 13:29 ` Oleg Nesterov
2013-08-05 14:27 ` Felipe Contreras
2013-08-05 14:39 ` Oleg Nesterov
2013-08-05 17:02 ` Felipe Contreras
2013-08-05 17:11 ` Oleg Nesterov
2013-08-05 17:40 ` Felipe Contreras
2013-08-05 17:56 ` Oleg Nesterov
2013-08-05 17:39 ` Linus Torvalds
2013-08-05 17:43 ` Felipe Contreras
2013-08-05 18:08 ` Felipe Contreras
2013-08-05 17:47 ` Oleg Nesterov
2013-08-05 18:46 ` Oleg Nesterov
2013-08-05 18:54 ` Linus Torvalds
2013-08-05 18:57 ` Oleg Nesterov [this message]
2013-08-05 19:06 ` Linus Torvalds
2013-08-06 15:43 ` [PATCH 0/1] (Was: Linux 3.11-rc4) Oleg Nesterov
2013-08-06 15:43 ` [PATCH 1/1] Revert "ptrace: PTRACE_DETACH should do flush_ptrace_hw_breakpoint(child)" Oleg Nesterov
2013-08-07 12:05 ` [PATCH 0/1] (Was: Linux 3.11-rc4) Grazvydas Ignotas
2013-08-07 17:22 ` Oleg Nesterov
2013-08-07 19:26 ` Linus Torvalds
2013-08-07 19:27 ` Oleg Nesterov
2013-08-07 19:47 ` Linus Torvalds
2013-08-08 15:41 ` Oleg Nesterov
2013-08-08 16:25 ` Linus Torvalds
2013-08-08 16:54 ` Frederic Weisbecker
2013-08-08 18:15 ` Oleg Nesterov
2013-08-09 16:45 ` Frederic Weisbecker
2013-08-09 17:12 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130805185712.GA12225@redhat.com \
--to=oleg@redhat.com \
--cc=felipe.contreras@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox