From: Simon Horman <horms@verge.net.au>
To: Xishi Qiu <qiuxishi@huawei.com>
Cc: zhangyanfei@cn.fujitsu.com, ebiederm@xmission.com,
kexec@lists.infradead.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] kexec: remove unnecessary return
Date: Tue, 6 Aug 2013 17:39:16 +0900 [thread overview]
Message-ID: <20130806083915.GC28493@verge.net.au> (raw)
In-Reply-To: <5200B534.7000202@huawei.com>
On Tue, Aug 06, 2013 at 04:35:00PM +0800, Xishi Qiu wrote:
> Code can not run here forever, so remove the unnecessary return.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> Suggested-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Reviewed-by: Simon Horman <horms@verge.net.au>
> ---
> kernel/kexec.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 59f7b55..2a74f30 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -1474,11 +1474,8 @@ static int __init __parse_crashkernel(char *cmdline,
> if (first_colon && (!first_space || first_colon < first_space))
> return parse_crashkernel_mem(ck_cmdline, system_ram,
> crash_size, crash_base);
> - else
> - return parse_crashkernel_simple(ck_cmdline, crash_size,
> - crash_base);
>
> - return 0;
> + return parse_crashkernel_simple(ck_cmdline, crash_size, crash_base);
> }
>
> /*
> --
> 1.7.1
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
next prev parent reply other threads:[~2013-08-06 8:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 8:35 [PATCH V2] kexec: remove unnecessary return Xishi Qiu
2013-08-06 8:39 ` Simon Horman [this message]
2013-08-06 8:44 ` Zhang Yanfei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130806083915.GC28493@verge.net.au \
--to=horms@verge.net.au \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiuxishi@huawei.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox