public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] warning-elimination: android: binder
@ 2013-08-06  3:36 Andy Green
  2013-08-06  9:40 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Andy Green @ 2013-08-06  3:36 UTC (permalink / raw)
  To: linux-kernel, Greg KH; +Cc: John Stultz, Mark Brown

From: Andy Green <andy.green@linaro.org>

warning-elimination: android: binder

This commit in mainline (now) causes a couple of warnings

commit 975a1ac9a9fe65d66ee1726c0db6dc58e53d232a
Author: Arve Hjønnevåg <arve@android.com>
Date:   Tue Oct 16 15:29:53 2012 -0700

    Staging: android: binder: Add some tracepoints

This patch fixes them

Signed-off-by: Andy Green <andy.green@linaro.org>
---

diff --git a/drivers/staging/android/binder_trace.h
b/drivers/staging/android/binder_trace.h
index 82a567c..c661e37 100644
--- a/drivers/staging/android/binder_trace.h
+++ b/drivers/staging/android/binder_trace.h
@@ -159,7 +159,7 @@ TRACE_EVENT(binder_transaction_node_to_ref,
  TP_fast_assign(
  __entry->debug_id = t->debug_id;
  __entry->node_debug_id = node->debug_id;
- __entry->node_ptr = node->ptr;
+ __entry->node_ptr = (void __user *)node->ptr;
  __entry->ref_debug_id = ref->debug_id;
  __entry->ref_desc = ref->desc;
  ),
@@ -184,7 +184,7 @@ TRACE_EVENT(binder_transaction_ref_to_node,
  __entry->ref_debug_id = ref->debug_id;
  __entry->ref_desc = ref->desc;
  __entry->node_debug_id = ref->node->debug_id;
- __entry->node_ptr = ref->node->ptr;
+ __entry->node_ptr = (void __user *)ref->node->ptr;
  ),
  TP_printk("transaction=%d node=%d src_ref=%d src_desc=%d ==> dest_ptr=0x%p",
   __entry->debug_id, __entry->node_debug_id,

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] warning-elimination: android: binder
  2013-08-06  3:36 [PATCH] warning-elimination: android: binder Andy Green
@ 2013-08-06  9:40 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2013-08-06  9:40 UTC (permalink / raw)
  To: Andy Green; +Cc: linux-kernel, John Stultz, Mark Brown

On Tue, Aug 06, 2013 at 11:36:19AM +0800, Andy Green wrote:
> From: Andy Green <andy.green@linaro.org>
> 
> warning-elimination: android: binder
> 
> This commit in mainline (now) causes a couple of warnings

What specifically are those warnings?  I don't see any here, so I'm
guessing your patch isn't really needed :)

(hint, hint, hint...)

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-08-06  9:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-06  3:36 [PATCH] warning-elimination: android: binder Andy Green
2013-08-06  9:40 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox