From: Lars Poeschel <poeschel@lemonage.de>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Lars Poeschel <larsi@wh2.tu-dresden.de>,
"b-cousson@ti.com" <b-cousson@ti.com>,
"tony@atomide.com" <tony@atomide.com>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
Pawel Moll <Pawel.Moll@arm.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"ian.campbell@citrix.com" <ian.campbell@citrix.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: am33xx: Correct gpio #interrupt-cells property
Date: Wed, 7 Aug 2013 17:11:00 +0200 [thread overview]
Message-ID: <201308071711.00449.poeschel@lemonage.de> (raw)
In-Reply-To: <20130807145309.GG28558@e106331-lin.cambridge.arm.com>
On Wednesday 07 August 2013 at 16:53:09, Mark Rutland wrote:
> On Wed, Aug 07, 2013 at 12:06:32PM +0100, Lars Poeschel wrote:
> > From: Lars Poeschel <poeschel@lemonage.de>
> >
> > Following commit ff5c9059 and therefore other omap platforms using
> > the gpio-omap driver correct the #interrupt-cells property on am33xx
> > too. The omap gpio binding documentaion also states that
> > the #interrupt-cells property should be 2.
>
> I take it there are no device nodes for which any of these nodes are an
> interrupt parent (which would need to be updated)?
As far as I know: No.
Lars
> If so:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
>
> Thanks,
> Mark.
>
> > Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
> > ---
> >
> > arch/arm/boot/dts/am33xx.dtsi | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/am33xx.dtsi
> > b/arch/arm/boot/dts/am33xx.dtsi index 38b446b..033c5dd 100644
> > --- a/arch/arm/boot/dts/am33xx.dtsi
> > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > @@ -102,7 +102,7 @@
> >
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> >
> > - #interrupt-cells = <1>;
> > + #interrupt-cells = <2>;
> >
> > reg = <0x44e07000 0x1000>;
> > interrupts = <96>;
> >
> > };
> >
> > @@ -113,7 +113,7 @@
> >
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> >
> > - #interrupt-cells = <1>;
> > + #interrupt-cells = <2>;
> >
> > reg = <0x4804c000 0x1000>;
> > interrupts = <98>;
> >
> > };
> >
> > @@ -124,7 +124,7 @@
> >
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> >
> > - #interrupt-cells = <1>;
> > + #interrupt-cells = <2>;
> >
> > reg = <0x481ac000 0x1000>;
> > interrupts = <32>;
> >
> > };
> >
> > @@ -135,7 +135,7 @@
> >
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> >
> > - #interrupt-cells = <1>;
> > + #interrupt-cells = <2>;
> >
> > reg = <0x481ae000 0x1000>;
> > interrupts = <62>;
> >
> > };
next prev parent reply other threads:[~2013-08-07 15:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 11:06 [PATCH] ARM: dts: am33xx: Correct gpio #interrupt-cells property Lars Poeschel
2013-08-07 11:27 ` Javier Martinez Canillas
2013-08-07 14:53 ` Mark Rutland
2013-08-07 15:11 ` Lars Poeschel [this message]
2013-08-13 13:25 ` Benoit Cousson
2013-08-21 7:50 ` Tony Lindgren
2013-08-21 7:57 ` Lars Poeschel
2013-08-21 7:59 ` Tony Lindgren
2013-08-21 9:25 ` Benoit Cousson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201308071711.00449.poeschel@lemonage.de \
--to=poeschel@lemonage.de \
--cc=Pawel.Moll@arm.com \
--cc=b-cousson@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=ian.campbell@citrix.com \
--cc=larsi@wh2.tu-dresden.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox