From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: David Ahern <dsahern@gmail.com>
Cc: linux-kernel@vger.kernel.org, xiaoguangrong@linux.vnet.ibm.com,
Ingo Molnar <mingo@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Runzhen Wang <runzhen@linux.vnet.ibm.com>
Subject: Re: [PATCH 4/5] perf kvm: option to print events that exceed a threshold
Date: Wed, 7 Aug 2013 17:34:37 -0300 [thread overview]
Message-ID: <20130807203437.GJ2665@ghostprotocols.net> (raw)
In-Reply-To: <5202ACF7.3020400@gmail.com>
Em Wed, Aug 07, 2013 at 04:24:23PM -0400, David Ahern escreveu:
> On 8/7/13 3:27 PM, Arnaldo Carvalho de Melo wrote:
> >Em Mon, Aug 05, 2013 at 09:41:36PM -0400, David Ahern escreveu:
> >So 'perf trace' has a similar option:
> >
> >[acme@zoo linux]$ perf trace --help
> ><SNIP>
> > --duration <float>
> > show only events with duration > N.M ms
> ><SNIP>
> >
> >While you used:
> >
> >>+ OPT_U64('T', "threshold", &kvm->threshold,
> >>+ "show events other than HALT that take longer than threshold usecs"),
> >
> >I prefer 'duration', and haven't assigned a single letter to it, they
> >are scarce and we have shell long option completion, what do you think?
> >
> >The term was chosen, for 'perf trace' on the original patchset:
> >
> >http://lwn.net/Articles/415728/
> No preference really. I need to send out an update to the man page.
> I can update this patch as well and re-send.
Please. I applied all the other patches, just wait a bit before I run
'male -C tools/perf -f tests/make' on my perf/core before I push it out.
- Arnaldo
next prev parent reply other threads:[~2013-08-07 20:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 1:41 [PATCH 0/5] perf kvm live - latest round take 4 David Ahern
2013-08-06 1:41 ` [PATCH 1/5] perf session: Export queue_event function David Ahern
2013-08-12 10:23 ` [tip:perf/core] " tip-bot for David Ahern
2013-08-06 1:41 ` [PATCH 2/5] perf kvm: add live mode - v4 David Ahern
2013-08-12 10:23 ` [tip:perf/core] perf kvm: Add live mode tip-bot for David Ahern
2013-08-06 1:41 ` [PATCH 3/5] perf kvm: add min and max stats to display - v2 David Ahern
2013-08-12 10:23 ` [tip:perf/core] perf kvm: Add min and max stats to display tip-bot for David Ahern
2013-08-06 1:41 ` [PATCH 4/5] perf kvm: option to print events that exceed a threshold David Ahern
2013-08-07 19:27 ` Arnaldo Carvalho de Melo
2013-08-07 20:24 ` David Ahern
2013-08-07 20:34 ` Arnaldo Carvalho de Melo [this message]
2013-08-06 1:41 ` [PATCH 5/5] perf kvm stat report: Add option to analyze specific VM David Ahern
2013-08-12 10:23 ` [tip:perf/core] " tip-bot for David Ahern
2013-08-06 5:45 ` [PATCH 0/5] perf kvm live - latest round take 4 Xiao Guangrong
2013-08-06 13:28 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130807203437.GJ2665@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=runzhen@linux.vnet.ibm.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).