public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Andrew Fish <afish@apple.com>
Cc: Matt Fleming <matt@console-pimps.org>,
	edk2-devel@lists.sourceforge.net,
	Laszlo Ersek <lersek@redhat.com>,
	linux-efi@vger.kernel.org, Gleb Natapov <gleb@redhat.com>,
	lkml <linux-kernel@vger.kernel.org>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [edk2] Corrupted EFI region
Date: Wed, 7 Aug 2013 22:23:02 +0100	[thread overview]
Message-ID: <20130807212302.GA10905@srcf.ucam.org> (raw)
In-Reply-To: <D5982201-6DC4-469F-812A-74A8402ADEE9@apple.com>

On Wed, Aug 07, 2013 at 02:10:28PM -0700, Andrew Fish wrote:

> Well the issue I see is I don't think OS X or Windows are doing this. 
> So I'm guessing there is some unique thing beings done on the Linux 
> side and we don't have good tests to catch bugs in the EFI 
> implementations. If the Linux loader hides the bugs and we don't hit 
> them with other operating systems they are never going to get fixed. 
> It would be good if we could track down some of these issues and make 
> a request for some tests that can help catch these issues. The tests 
> would be part of UEFI.org, but since some of us play in both worlds we 
> can forward the known issues to the UEFI test work group.

Linux enables NX before calling SetVirtualAddressMap(). If other OSes 
don't do that, you probably won't see the bug.

> Is it possible to have a switch to turn off the not required behavior 
> (hiding EFI implementation bugs) so that bad platforms could be 
> detected? This would be a good thing to try on platforms at the 
> upcoming UEFI Plugfest hosted by the Linux Foundation and the UEFI 
> Forum, so the bad behavior can be detected and the vendors can fix the 
> issue.

It's behaviour that we already have to work around due to shipping 
hardware exhibiting it, so while we could certainly develop a test, 
Linux is always going to need to include the workaround code.

That being said, some of what we do with the memory map in Linux right 
now is probably unnecessary - we're modifying the memory map because 
that's a convenient place to store the information, rather than because 
the memory map actually needs to be modified. We could do a better job 
of that.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2013-08-07 21:23 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-31 20:54 Corrupted EFI region Borislav Petkov
2013-07-31 20:58 ` Matthew Garrett
2013-07-31 21:51   ` Borislav Petkov
2013-07-31 21:54     ` Matthew Garrett
2013-08-01 16:51       ` Borislav Petkov
2013-07-31 21:55 ` David Woodhouse
2013-08-01 16:49   ` Borislav Petkov
2013-08-05 11:27     ` [edk2] " Laszlo Ersek
2013-08-05 13:02       ` Borislav Petkov
2013-08-05 13:39         ` Laszlo Ersek
2013-08-05 14:03           ` Borislav Petkov
2013-08-05 14:27             ` Laszlo Ersek
2013-08-05 14:40               ` Borislav Petkov
2013-08-05 15:15                 ` Laszlo Ersek
2013-08-05 15:34                   ` James Bottomley
2013-08-05 16:27                     ` Laszlo Ersek
2013-08-05 16:12                   ` Borislav Petkov
2013-08-05 16:41                     ` Laszlo Ersek
2013-08-05 16:47                       ` Borislav Petkov
2013-08-05 17:00                         ` Kinney, Michael D
2013-08-05 17:09                         ` Laszlo Ersek
2013-08-05 21:26                         ` Laszlo Ersek
2013-08-05 22:08                           ` Borislav Petkov
2013-08-06 14:10                             ` Borislav Petkov
2013-08-06 15:31                               ` Laszlo Ersek
2013-08-07 15:19                                 ` Borislav Petkov
2013-08-07 17:23                                   ` Andrew Fish
2013-08-07 20:19                                     ` Matt Fleming
2013-08-07 20:24                                       ` Matt Fleming
2013-08-07 21:10                                       ` Andrew Fish
2013-08-07 21:23                                         ` Matthew Garrett [this message]
2013-08-08 10:17                                         ` Matt Fleming
2013-08-08 13:46                                           ` Andrew Fish
2013-09-02  8:19                                             ` Matt Fleming
2013-09-13 20:38                                           ` jerry.hoemann
2013-09-16 10:59                                             ` Matt Fleming
2013-09-16 11:50                                               ` Laszlo Ersek
2013-09-16 15:57                                                 ` Josh Triplett
2013-09-16 16:25                                                   ` Laszlo Ersek
2013-09-16 16:27                                                     ` Matthew Garrett
2013-09-16 16:29                                                     ` Josh Triplett
2013-09-18 19:24                                               ` jerry.hoemann
2013-09-20  9:06                                                 ` Matt Fleming
2013-08-07 17:49                                   ` Laszlo Ersek
2013-08-08 15:02                                     ` Borislav Petkov
2013-08-08 21:45                                       ` Brian J. Johnson
2013-08-18  7:33                                     ` Jordan Justen
2013-08-05 15:50                 ` Andrew Fish
2013-08-05 18:12                   ` Borislav Petkov
2013-08-05 21:37                     ` H. Peter Anvin
2013-08-05 21:41                       ` Borislav Petkov
2013-08-05 21:49                         ` H. Peter Anvin
2013-08-05 21:55                         ` Laszlo Ersek
2013-08-05 22:52                           ` James Bottomley
2013-08-06  7:26                             ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130807212302.GA10905@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=afish@apple.com \
    --cc=dwmw2@infradead.org \
    --cc=edk2-devel@lists.sourceforge.net \
    --cc=gleb@redhat.com \
    --cc=lersek@redhat.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@console-pimps.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox