From: Dan Carpenter <dan.carpenter@oracle.com>
To: Paul McQuade <paulmcquad@gmail.com>
Cc: gregkh@linuxfoundation.org,
Linux-Devel <devel@driverdev.osuosl.org>,
Linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] Staging: BCM: Removed more whitespace/Errors
Date: Thu, 8 Aug 2013 23:44:55 +0300 [thread overview]
Message-ID: <20130808204455.GC5502@mwanda> (raw)
In-Reply-To: <5203CF75.802@gmail.com>
On Thu, Aug 08, 2013 at 06:03:49PM +0100, Paul McQuade wrote:
> -int InterfaceFileDownload( PVOID psIntfAdapter,
> - struct file *flp,
> - unsigned int on_chip_loc);
> +int InterfaceFileDownload(PVOID psIntfAdapter,
> + struct file *flp,
> + unsigned int on_chip_loc);
The very first line in this patch is totally wrong... :(
This is an automated patch. I'm not going to review any further.
Automated patches create a problem for reviews because they are
far harder to review than they are to generate. I'm not sure what
the solution is...
Anyway, the patch is very wrong.
regards,
dan carpenter
next prev parent reply other threads:[~2013-08-08 20:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 17:03 [PATCH 2/2] Staging: BCM: Removed more whitespace/Errors Paul McQuade
2013-08-08 17:23 ` Joe Perches
2013-08-08 20:44 ` Dan Carpenter [this message]
2013-08-08 21:03 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130808204455.GC5502@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmcquad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox