Re: [PATCH 0/22] Immutable biovecs, block layer changes

Christoph Hellwig
2013-09-24T14:29:42Z

On Tue, Sep 24, 2013 at 09:20:14AM -0400, Mike Snitzer wrote:
> Have you been over the patchset? Looks sane to you?

I looked over it, although I didn't dig into the details of all driver
patches, and I like what I see. As said in the previous mail I'd love
to see the patches to shrink struct bio again, too.

> Given how disruptive this patchset is to the block layer I'm wondering
> how painful this change will be in combination with Jens' blk-mq
> changes. I'd prefer to see blk-mq before immutable biovecs; but I have
> my own selfish reasons for that.

I don't see too much conflicts with blk-multiqueue as that is operating
at the request layer. Blk-multiqueue defintively is a higher priority
for me, but as it already looks fairly good I have no idea what we're
blocked on for it anyway.