Re: [PATCH 04/22] block: Abstract out bvec iterator

Geoff Levand
2013-08-07T22:24:17Z

Hi Kent,

On Wed, 2013-08-07 at 14:54 -0700, Kent Overstreet wrote:
> Immutable biovecs are going to require an explicit iterator. To
> implement immutable bvecs, a later patch is going to add a bi_bvec_done
> member to this struct; for now, this patch effectively just renames
> things.

> diff --git a/drivers/block/ps3disk.c b/drivers/block/ps3disk.c
> index d754a88..464be78 100644
> --- a/drivers/block/ps3disk.c
> +++ b/drivers/block/ps3disk.c
> @@ -104,7 +104,7 @@ static void ps3disk_scatter_gather(struct ps3_storage_device *dev,
> dev_dbg(&dev->sbd.core,
> "%s:%u: bio %u: %u segs %u sectors from %lu\n",
> __func__, __LINE__, i, bio_segments(iter.bio),
> - bio_sectors(iter.bio), iter.bio->bi_sector);
> + bio_sectors(iter.bio), iter.bio->bi_iter.bi_sector);
>
> size = bvec->bv_len;
> buf = bvec_kmap_irq(bvec, &flags);

The ps3 part looks OK. Please try a build test with the powerpc
defconfig_ps3 if you can.

Acked-by: Geoff Levand <geoff@infradead.org>