From: Daniel Drake <dsd@laptop.org>
To: akpm@linux-foundation.org
Cc: dilinger@queued.net, linux-kernel@vger.kernel.org
Subject: [PATCH] olpc-ec: initialise earlier
Date: Sat, 10 Aug 2013 15:22:15 -0400 (EDT) [thread overview]
Message-ID: <20130810192215.B83A2FAB04@dev.laptop.org> (raw)
Being a low-level component, various drivers (e.g. olpc-battery) assume that
it is ok to communicate with the OLPC Embedded Controller during probe.
Therefore the OLPC EC driver must be initialised before other drivers try to
use it. This was the case until it was recently moved out of arch/x86 and
restructured.
Use arch_initcall so that olpc-ec is readied earlier, matching the
previous behaviour. Fixes various drivers such as olpc-battery and
olpc-xo1-sci.
Signed-off-by: Daniel Drake <dsd@laptop.org>
---
drivers/platform/olpc/olpc-ec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/olpc/olpc-ec.c b/drivers/platform/olpc/olpc-ec.c
index 0f9f859..f911952 100644
--- a/drivers/platform/olpc/olpc-ec.c
+++ b/drivers/platform/olpc/olpc-ec.c
@@ -330,7 +330,7 @@ static int __init olpc_ec_init_module(void)
return platform_driver_register(&olpc_ec_plat_driver);
}
-module_init(olpc_ec_init_module);
+arch_initcall(olpc_ec_init_module);
MODULE_AUTHOR("Andres Salomon <dilinger@queued.net>");
MODULE_LICENSE("GPL");
--
1.8.3.1
next reply other threads:[~2013-08-10 19:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-10 19:22 Daniel Drake [this message]
2013-08-14 22:14 ` [PATCH] olpc-ec: initialise earlier Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130810192215.B83A2FAB04@dev.laptop.org \
--to=dsd@laptop.org \
--cc=akpm@linux-foundation.org \
--cc=dilinger@queued.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox