* [PATCH] FMC: Staticize local symbols
@ 2013-08-12 3:35 Jingoo Han
2013-08-12 12:44 ` Alessandro Rubini
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-08-12 3:35 UTC (permalink / raw)
To: 'Alessandro Rubini'; +Cc: linux-kernel, Greg Kroah-Hartman, Jingoo Han
This local symbol is used only in this file.
Fix the following sparse warnings:
drivers/fmc/fmc-write-eeprom.c:106:5: warning: symbol 'fwe_probe' was not declared. Should it be static?
drivers/fmc/fmc-write-eeprom.c:147:5: warning: symbol 'fwe_remove' was not declared. Should it be static?
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/fmc/fmc-write-eeprom.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/fmc/fmc-write-eeprom.c b/drivers/fmc/fmc-write-eeprom.c
index 2cc680d..ee5b479 100644
--- a/drivers/fmc/fmc-write-eeprom.c
+++ b/drivers/fmc/fmc-write-eeprom.c
@@ -103,7 +103,7 @@ static int fwe_run(struct fmc_device *fmc, const struct firmware *fw, char *s)
* difficult to know in advance when probing the first card if others
* are there.
*/
-int fwe_probe(struct fmc_device *fmc)
+static int fwe_probe(struct fmc_device *fmc)
{
int err, index = 0;
const struct firmware *fw;
@@ -144,7 +144,7 @@ int fwe_probe(struct fmc_device *fmc)
return 0;
}
-int fwe_remove(struct fmc_device *fmc)
+static int fwe_remove(struct fmc_device *fmc)
{
return 0;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] FMC: Staticize local symbols
2013-08-12 3:35 [PATCH] FMC: Staticize local symbols Jingoo Han
@ 2013-08-12 12:44 ` Alessandro Rubini
0 siblings, 0 replies; 2+ messages in thread
From: Alessandro Rubini @ 2013-08-12 12:44 UTC (permalink / raw)
To: jg1.han; +Cc: linux-kernel, gregkh
> This local symbol is used only in this file.
> Fix the following sparse warnings:
Thanks!
Acked-by: Alessandro Rubini <rubini@gnudd.com>
/alessandro
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-12 12:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-12 3:35 [PATCH] FMC: Staticize local symbols Jingoo Han
2013-08-12 12:44 ` Alessandro Rubini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).